From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org
Subject: Re: [vta, graphite?] propagate degenerate phi nodes into debug stmts
Date: Wed, 23 Dec 2009 08:58:00 -0000 [thread overview]
Message-ID: <6dc9ffc80912221655x1d1755c8nc41f66649a5a8f7a@mail.gmail.com> (raw)
In-Reply-To: <6dc9ffc80912050502t5420c654qbb7dc7acc8782b9c@mail.gmail.com>
On Sat, Dec 5, 2009 at 5:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Nov 20, 2009 at 1:23 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>> On Nov 19, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>>
>>> On Thu, Nov 19, 2009 at 5:27 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>>>> On Nov 17, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>>>>
>>>>> Well, just adjust degenerate_phi_result to do instead of calling
>>>>> operand_equal_p
>>>>
>>>>> else if (TREE_CODE (arg) != TREE_CODE (val)
>>>>> || (TREE_CODE (arg) == SSA_NAME
>>>>> && arg != val)
>>>>> || !operand_equal_p (arg, val, 0))
>>>>> break;
>>>>
>>>>> that should fix it.
>>>>
>>>> Good idea.
>>
>>>> Here's what I'm testing now.
>>
>>> Ok if it passes testing.
>>
>> Thanks, but arg could be NULL, and then TREE_CODE (val) would crash.
>>
>> The fixed patch below corrects the two regressions I got testing the
>> patch on x86_64-linux-gnu. Save for new regressions, I'll check in the
>> revised version as soon as my current round of testing completes.
>>
>>
>
> This patch caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42299
>
This patch also caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42395
--
H.J.
next prev parent reply other threads:[~2009-12-23 0:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-08 8:07 Alexandre Oliva
2009-11-08 9:57 ` Richard Guenther
2009-11-16 20:35 ` Alexandre Oliva
2009-11-16 20:48 ` Alexandre Oliva
2009-11-17 15:47 ` Richard Guenther
2009-11-19 4:18 ` Alexandre Oliva
2009-11-19 10:56 ` Richard Guenther
2009-11-20 9:37 ` Alexandre Oliva
2009-11-20 10:47 ` Richard Guenther
2009-11-21 5:22 ` Alexandre Oliva
2011-06-03 14:38 ` Alexandre Oliva
2011-06-06 9:37 ` Richard Guenther
2011-06-07 10:38 ` Alexandre Oliva
2011-06-07 12:04 ` Richard Guenther
2009-11-19 4:28 ` Alexandre Oliva
2009-11-19 10:59 ` Richard Guenther
2009-11-20 9:26 ` Alexandre Oliva
2009-12-05 16:04 ` H.J. Lu
2009-12-23 8:58 ` H.J. Lu [this message]
2010-01-29 17:02 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc9ffc80912221655x1d1755c8nc41f66649a5a8f7a@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=aoliva@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).