From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-254743-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 23703 invoked by alias); 23 Dec 2009 00:55:19 -0000
Received: (qmail 23502 invoked by uid 22791); 23 Dec 2009 00:55:19 -0000
X-SWARE-Spam-Status: No, hits=-0.1 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS,SUBJECT_FUZZY_VPILL
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f227.google.com (HELO mail-ew0-f227.google.com) (209.85.219.227)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Dec 2009 00:55:14 +0000
Received: by ewy27 with SMTP id 27so8289024ewy.16         for <gcc-patches@gcc.gnu.org>; Tue, 22 Dec 2009 16:55:11 -0800 (PST)
MIME-Version: 1.0
Received: by 10.216.93.77 with SMTP id k55mr3684395wef.196.1261529711633; Tue,  	22 Dec 2009 16:55:11 -0800 (PST)
In-Reply-To: <6dc9ffc80912050502t5420c654qbb7dc7acc8782b9c@mail.gmail.com>
References: <orfx8ph31l.fsf@livre.localdomain> 	 <84fc9c000911080156iff6d687o26db10af3e9fba5d@mail.gmail.com> 	 <ortywuw6bb.fsf@livre.localdomain> 	 <84fc9c000911170739v76a2e911vc6794e597c8d134e@mail.gmail.com> 	 <ord43fgmvw.fsf@livre.localdomain> 	 <84fc9c000911190255q12e2a1c8nc0af0587883d7455@mail.gmail.com> 	 <orfx89eei5.fsf@livre.localdomain> 	 <6dc9ffc80912050502t5420c654qbb7dc7acc8782b9c@mail.gmail.com>
Date: Wed, 23 Dec 2009 08:58:00 -0000
Message-ID: <6dc9ffc80912221655x1d1755c8nc41f66649a5a8f7a@mail.gmail.com>
Subject: Re: [vta, graphite?] propagate degenerate phi nodes into debug stmts
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Richard Guenther <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2009-12/txt/msg01060.txt.bz2

On Sat, Dec 5, 2009 at 5:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Nov 20, 2009 at 1:23 AM, Alexandre Oliva <aoliva@redhat.com> wrot=
e:
>> On Nov 19, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>>
>>> On Thu, Nov 19, 2009 at 5:27 AM, Alexandre Oliva <aoliva@redhat.com> wr=
ote:
>>>> On Nov 17, 2009, Richard Guenther <richard.guenther@gmail.com> wrote:
>>>>
>>>>> Well, just adjust degenerate_phi_result to do instead of calling
>>>>> operand_equal_p
>>>>
>>>>> =A0 else if (TREE_CODE (arg) !=3D TREE_CODE (val)
>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0|| (TREE_CODE (arg) =3D=3D SSA_NAME
>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&& arg !=3D val)
>>>>> =A0 =A0 =A0 =A0 =A0 =A0 =A0|| !operand_equal_p (arg, val, 0))
>>>>> =A0 =A0 break;
>>>>
>>>>> that should fix it.
>>>>
>>>> Good idea.
>>
>>>> Here's what I'm testing now.
>>
>>> Ok if it passes testing.
>>
>> Thanks, but arg could be NULL, and then TREE_CODE (val) would crash.
>>
>> The fixed patch below corrects the two regressions I got testing the
>> patch on x86_64-linux-gnu. =A0Save for new regressions, I'll check in the
>> revised version as soon as my current round of testing completes.
>>
>>
>
> This patch caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D42299
>

This patch also caused:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D42395

--=20
H.J.