From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jason Merrill <jason@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 5)
Date: Sun, 27 Dec 2009 13:36:00 -0000 [thread overview]
Message-ID: <6dc9ffc80912261306q7eac03b4re6614feaf57fe26@mail.gmail.com> (raw)
In-Reply-To: <20091201192247.GT22813@hs20-bc2-1.build.redhat.com>
On Tue, Dec 1, 2009 at 11:22 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> After discussions on IRC, here is the latest version of the patch.
> For now the problematic implicitly defined virtual comdat destructors aren't
> optimized, even when the base and complete dtor have the same body, as the
> deleting dtor isn't necessarily emitted iff the base/complete dtors are
> emitted.
>
> The nice effect of that patch is that the libstdc++ symbol version script
> changes aren't needed.
>
> Bootstrapped/regtested on x86_64-linux (with the checking patch on top of
> it), ok for trunk?
>
This caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42508
--
H.J.
next prev parent reply other threads:[~2009-12-26 21:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 22:38 [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3) Jakub Jelinek
2009-12-01 3:53 ` Jason Merrill
2009-12-01 8:07 ` Jakub Jelinek
2009-12-01 15:39 ` Jason Merrill
2009-12-01 9:52 ` [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 4) Jakub Jelinek
2009-12-01 15:40 ` Jakub Jelinek
2009-12-01 16:38 ` Dave Korn
2009-12-01 19:35 ` [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 5) Jakub Jelinek
2009-12-01 20:14 ` Jason Merrill
2009-12-01 21:03 ` Dave Korn
2009-12-04 18:19 ` Dave Korn
2009-12-04 18:29 ` Jakub Jelinek
2009-12-04 18:46 ` Dave Korn
2009-12-27 13:36 ` H.J. Lu [this message]
2009-12-01 21:15 ` [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3) Daniel Jacobowitz
2009-12-01 21:20 ` Jakub Jelinek
2009-12-01 21:50 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dc9ffc80912261306q7eac03b4re6614feaf57fe26@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).