From: Jeff Law <law@redhat.com>
To: Tamar Christina <Tamar.Christina@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
nd <nd@arm.com>, James Greenhalgh <James.Greenhalgh@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [PATCH][GCC][AArch64] Updated stack-clash implementation supporting 64k probes. [patch (1/6)]
Date: Fri, 03 Aug 2018 18:04:00 -0000 [thread overview]
Message-ID: <6ddb6ede-4abb-fcfd-862a-6531c34cc6f5@redhat.com> (raw)
In-Reply-To: <HE1SPR8PMB31333110BD5F40352F02DF4FF540@HE1SPR8PMB313.eurprd08.prod.outlook.com>
On 07/25/2018 05:09 AM, Tamar Christina wrote:
> Hi All,
>
> Attached is an updated patch that clarifies some of the comments in the patch and adds comments to the individual testcases
> as requested.
>
> Ok for trunk?
>
> Thanks,
> Tamar
>
> gcc/
> 2018-07-25 Jeff Law <law@redhat.com>
> Richard Sandiford <richard.sandiford@linaro.org>
> Tamar Christina <tamar.christina@arm.com>
>
> PR target/86486
> * config/aarch64/aarch64.md (cmp<mode>,
> probe_stack_range): Add k (SP) constraint.
> * config/aarch64/aarch64.h (STACK_CLASH_CALLER_GUARD,
> STACK_CLASH_MAX_UNROLL_PAGES): New.
> * config/aarch64/aarch64.c (aarch64_output_probe_stack_range): Emit
> stack probes for stack clash.
> (aarch64_allocate_and_probe_stack_space): New.
> (aarch64_expand_prologue): Use it.
> (aarch64_expand_epilogue): Likewise and update IP regs re-use criteria.
> (aarch64_sub_sp): Add emit_move_imm optional param.
>
> gcc/testsuite/
> 2018-07-25 Jeff Law <law@redhat.com>
> Richard Sandiford <richard.sandiford@linaro.org>
> Tamar Christina <tamar.christina@arm.com>
>
> PR target/86486
> * gcc.target/aarch64/stack-check-12.c: New.
> * gcc.target/aarch64/stack-check-13.c: New.
> * gcc.target/aarch64/stack-check-cfa-1.c: New.
> * gcc.target/aarch64/stack-check-cfa-2.c: New.
> * gcc.target/aarch64/stack-check-prologue-1.c: New.
> * gcc.target/aarch64/stack-check-prologue-10.c: New.
> * gcc.target/aarch64/stack-check-prologue-11.c: New.
> * gcc.target/aarch64/stack-check-prologue-2.c: New.
> * gcc.target/aarch64/stack-check-prologue-3.c: New.
> * gcc.target/aarch64/stack-check-prologue-4.c: New.
> * gcc.target/aarch64/stack-check-prologue-5.c: New.
> * gcc.target/aarch64/stack-check-prologue-6.c: New.
> * gcc.target/aarch64/stack-check-prologue-7.c: New.
> * gcc.target/aarch64/stack-check-prologue-8.c: New.
> * gcc.target/aarch64/stack-check-prologue-9.c: New.
> * gcc.target/aarch64/stack-check-prologue.h: New.
> * lib/target-supports.exp
> (check_effective_target_supports_stack_clash_protection): Add AArch64.
OK on my end. AArch64 maintainers have the final say since this is all
AArch64 specific bits.
jeff
next prev parent reply other threads:[~2018-08-03 18:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 11:20 Tamar Christina
2018-07-11 17:00 ` Jeff Law
2018-07-11 17:31 ` Jeff Law
2018-07-12 17:40 ` Tamar Christina
2018-07-13 16:35 ` Tamar Christina
2018-07-13 16:46 ` Jeff Law
2018-07-16 13:55 ` Tamar Christina
2018-07-16 17:03 ` Jeff Law
2018-07-25 11:09 ` Tamar Christina
2018-08-03 18:04 ` Jeff Law [this message]
2018-08-07 10:09 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ddb6ede-4abb-fcfd-862a-6531c34cc6f5@redhat.com \
--to=law@redhat.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).