From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id AF76B3858C50; Tue, 23 Apr 2024 08:59:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF76B3858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF76B3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713862771; cv=none; b=YLMZpLepUgAtgJinJL06yfKJ5WIwGKtvYs9/FLn7zcZP3E2pxmG39bwX/ajihlg73KpYbVhwkLSFCvlWLdA7NEGSAzXjJZiJvJf7/OFeb1hY83+PjbSal9xlfixrrR9La9Flh/z1srPEGbTjuxviatRBBqstwycw+Nkt75RWHOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713862771; c=relaxed/simple; bh=6B2x5U+PoG39b7++K0BY4AdRRTNvWn5sbfjhVlsOlrw=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=NcxrQH1BXk3ZbhnEU+jRqvPJM+0PXotvtowAll+roufxrnk7vP5Ph/YnlfqLfcDhE/ZIlm0/9gv6UfnBbC3/Sx4L3H5JzRu4UJ2s1/Fgzp41PMsne7MMATLlaFOfw1xuSjouF8/eXoRj/Q84T5jqOboRYxDK0slH8ioMvvfqDTM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43N8hmva002534; Tue, 23 Apr 2024 08:59:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=9Lm3nHUv/vJvMuJkCE+jm/BaQMig8jVixkK8soeJRw8=; b=D7JERx54m0ma0344doPTYNrnfSu24cy1W1dEAjCoztmLb4KEa6cHVaa5O8etFj0IXCsf UKt3WHO4cjVAfVCI8wvTYjjsOlQlCro17SNbdcYFoGzHmlATM+BTdh2j4gcoDCaivXKS dnaCH8pM5GuskRg/14BINz9828GKxEBjw67+sBevJOP0RYJHzkMl2WURFzPGYKfYywDf 2Ljb1hdXhfxn2rU+mK0IIifdnyGkRZQEZhlBviqGli4rTyja21mnDmhjmXadKApB/ig7 wfTh+C0D+kSrMZRcgiGCHvKFRaF2nraKcHALbCjW64prB22AEVbENNqVji+rPyPN2ce6 cw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xp9gmg1h9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 08:59:23 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43N8xNU3031621; Tue, 23 Apr 2024 08:59:23 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xp9gmg1h5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 08:59:23 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43N84796023068; Tue, 23 Apr 2024 08:59:22 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xms1nvmuc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 08:59:22 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43N8xIXL44499414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Apr 2024 08:59:20 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5364B20040; Tue, 23 Apr 2024 08:59:18 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 07CDD2004B; Tue, 23 Apr 2024 08:59:15 +0000 (GMT) Received: from [9.200.55.181] (unknown [9.200.55.181]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 23 Apr 2024 08:59:14 +0000 (GMT) Message-ID: <6de1dd9d-de60-6a0c-7a25-67533957e62b@linux.ibm.com> Date: Tue, 23 Apr 2024 16:59:13 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] [testsuite] require sqrt_insn effective target where needed Content-Language: en-US To: Alexandre Oliva Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , Hans-Peter Nilsson , gcc-patches@gcc.gnu.org, Iain Sandoe , Richard Biener References: From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 2wlp8poyoVaDG3MgHXB1hzBNGCeg8tX- X-Proofpoint-GUID: sqMVRdeOGxNV08kKli6pWAihdpThpN-N Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-23_07,2024-04-22_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 suspectscore=0 impostorscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1011 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404230024 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, on 2024/4/22 17:56, Alexandre Oliva wrote: > This patch takes feedback received for 3 earlier patches, and adopts a > simpler approach to skip the still-failing tests, that I believe to be > in line with ppc maintainers' expressed preferences. > https://gcc.gnu.org/pipermail/gcc-patches/2021-February/565939.html > https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566617.html > https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566521.html > Ping?-ish :-) > > > Some tests fail on ppc and ppc64 when testing a compiler [with options > for] for a CPU [emulator] that doesn't support the sqrt insn. > > The gcc.dg/cdce3.c is one in which the expected shrink-wrap > optimization only takes place when the target CPU supports a sqrt > insn. > > The gcc.target/powerpc/pr46728-1[0-4].c tests use -mpowerpc-gpopt and > call sqrt(), which involves the sqrt insn that the target CPU under > test may not support. > > Require a sqrt_insn effective target for all the affected tests. > > Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also testing > with gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.dg/cdce3.c: Require sqrt_insn effective target. > * gcc.target/powerpc/pr46728-10.c: Likewise. > * gcc.target/powerpc/pr46728-11.c: Likewise. > * gcc.target/powerpc/pr46728-13.c: Likewise. > * gcc.target/powerpc/pr46728-14.c: Likewise. > --- > gcc/testsuite/gcc.dg/cdce3.c | 3 ++- > gcc/testsuite/gcc.target/powerpc/pr46728-10.c | 1 + > gcc/testsuite/gcc.target/powerpc/pr46728-11.c | 1 + > gcc/testsuite/gcc.target/powerpc/pr46728-13.c | 1 + > gcc/testsuite/gcc.target/powerpc/pr46728-14.c | 1 + > 5 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/cdce3.c b/gcc/testsuite/gcc.dg/cdce3.c > index 601ddf055fd71..f759a95972e8b 100644 > --- a/gcc/testsuite/gcc.dg/cdce3.c > +++ b/gcc/testsuite/gcc.dg/cdce3.c > @@ -1,7 +1,8 @@ > /* { dg-do compile } */ > /* { dg-require-effective-target hard_float } */ > +/* { dg-require-effective-target sqrt_insn } */ > /* { dg-options "-O2 -fmath-errno -fdump-tree-cdce-details -fdump-tree-optimized" } */ > -/* { dg-final { scan-tree-dump "cdce3.c:11: \[^\n\r]* function call is shrink-wrapped into error conditions\." "cdce" } } */ > +/* { dg-final { scan-tree-dump "cdce3.c:12: \[^\n\r]* function call is shrink-wrapped into error conditions\." "cdce" } } */ > /* { dg-final { scan-tree-dump "sqrtf \\(\[^\n\r]*\\); \\\[tail call\\\]" "optimized" } } */ > /* { dg-skip-if "doesn't have a sqrtf insn" { mmix-*-* } } */ > This change needs an approval from global maintainer as it touches a generic test case? > diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c > index 3be4728d333a4..7e9bb638106c2 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr46728-10.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-10.c > @@ -1,6 +1,7 @@ > /* { dg-do run } */ > /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ > /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ > +/* { dg-require-effective-target sqrt_insn } */ This change looks sensible to me. Nit: With the proposed change, I'd expect that we can remove the line for powerpc*-*-darwin*. CC Iain to confirm. BR, Kewen > > #include > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-11.c b/gcc/testsuite/gcc.target/powerpc/pr46728-11.c > index 43b6728a4b812..5bfa25925675a 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr46728-11.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-11.c > @@ -1,6 +1,7 @@ > /* { dg-do run } */ > /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ > /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ > +/* { dg-require-effective-target sqrt_insn } */ > > #include > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-13.c b/gcc/testsuite/gcc.target/powerpc/pr46728-13.c > index b9fd63973b728..b66d0209a5e54 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr46728-13.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-13.c > @@ -1,6 +1,7 @@ > /* { dg-do run } */ > /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ > /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ > +/* { dg-require-effective-target sqrt_insn } */ > > #include > > diff --git a/gcc/testsuite/gcc.target/powerpc/pr46728-14.c b/gcc/testsuite/gcc.target/powerpc/pr46728-14.c > index 5affff13bdb6c..71a1a70c4e7a2 100644 > --- a/gcc/testsuite/gcc.target/powerpc/pr46728-14.c > +++ b/gcc/testsuite/gcc.target/powerpc/pr46728-14.c > @@ -1,6 +1,7 @@ > /* { dg-do run } */ > /* { dg-skip-if "-mpowerpc-gpopt not supported" { powerpc*-*-darwin* } } */ > /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ > +/* { dg-require-effective-target sqrt_insn } */ > > #include > >