From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 53E163857C4A for ; Fri, 24 Jun 2022 01:04:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53E163857C4A Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25NNBGM6017797; Fri, 24 Jun 2022 01:04:07 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gvyu1mf3v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jun 2022 01:04:07 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 25O0mhHi027135; Fri, 24 Jun 2022 01:04:07 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gvyu1mf37-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jun 2022 01:04:07 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25O0oWw1013370; Fri, 24 Jun 2022 01:04:05 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma03ams.nl.ibm.com with ESMTP id 3gvuj7rfwb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jun 2022 01:04:05 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25O13DB922413800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jun 2022 01:03:13 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3144A4054; Fri, 24 Jun 2022 01:04:02 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A152A405B; Fri, 24 Jun 2022 01:04:01 +0000 (GMT) Received: from [9.197.246.188] (unknown [9.197.246.188]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 24 Jun 2022 01:04:00 +0000 (GMT) Message-ID: <6ded988f-6684-e42e-ca82-d81ff55178d2@linux.ibm.com> Date: Fri, 24 Jun 2022 09:03:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3] rs6000: Adjust mov optabs for opaque modes [PR103353] Content-Language: en-US To: Segher Boessenkool , Peter Bergner Cc: GCC Patches , David Edelsohn , will schmidt References: <09c34b29-feea-d26e-2c4f-5e096ab286bc@linux.ibm.com> <20220623190619.GU25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: <20220623190619.GU25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 3Pv_EtR5jmPk-4JRHn791YmxZ7bqB6gU X-Proofpoint-GUID: apbFJObFu8dybZ_12LBLTXKkWBAu8zXT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-23_11,2022-06-23_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 suspectscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 lowpriorityscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206240000 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 01:04:11 -0000 Hi Segher, Thanks for the comments. on 2022/6/24 03:06, Segher Boessenkool wrote: > Hi! > > On Wed, May 18, 2022 at 10:07:48PM +0800, Kewen.Lin wrote: >> As PR103353 shows, we may want to continue to expand a MMA built-in >> function like a normal function, even if we have already emitted >> error messages about some missing required conditions. As shown in >> that PR, without one explicit mov optab on OOmode provided, it would >> call emit_move_insn recursively. > > First off: lxvp is a VSX insn, not an MMA insn. So please don't call it > that -- this confusion is what presumably caused the problem here, so it > would be good to root it out :-) > I guess the "it" in "don't call it call" is for "MMA built-in function"? It comes from the current code: ; mma Needs special handling for MMA ; quad MMA instruction using a register quad as an input operand ; pair MMA instruction using a register pair as an input operand v256 __builtin_vsx_lxvp (unsigned long, const v256 *); LXVP nothing {mma} void __builtin_vsx_stxvp (v256, unsigned long, const v256 *); STXVP nothing {mma,pair} ... >> + /* Opaque modes are only expected to be available when MMA is supported, > > Why do people expect that? It is completely wrong. The name "opaque" > itself already says this is not just for MMA, but perhaps more > importantly, it is a basic VSX insn, doesn't touch any MMA resources, > and is useful in other contexts as well. > ... The above statements are also based on current code, for now, the related things like built-in functions, mov optab, hard_regno_ok etc. for these two modes are guarded by TARGET_MMA. I think I get your points here, you want to separate these opaque modes from MMA since the underlying lxvp/stxvp are not MMA specific, so those related things (bifs, mov optabs etc.) are not necessarily guarded under MMA. > So this needs some bigger surgery. Yes, Peter may have more comments on this. BR, Kewen