From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50936 invoked by alias); 8 May 2017 17:33:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 50896 invoked by uid 89); 8 May 2017 17:33:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:988 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mtaout004-public.msg.strl.va.charter.net Received: from mtaout004-public.msg.strl.va.charter.net (HELO mtaout004-public.msg.strl.va.charter.net) (68.114.190.29) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 08 May 2017 17:33:52 +0000 Received: from impout002 ([68.114.189.17]) by mtaout004.msg.strl.va.charter.net (InterMail vM.9.00.023.01 201-2473-194) with ESMTP id <20170508173352.DRMQ3685.mtaout004.msg.strl.va.charter.net@impout002>; Mon, 8 May 2017 12:33:52 -0500 Received: from [192.168.2.11] ([96.41.215.23]) by impout002 with charter.net id HtZr1v0040Wrkg001tZrgi; Mon, 08 May 2017 12:33:52 -0500 X-Authority-Analysis: v=2.2 cv=K7tSJ2eI c=1 sm=1 tr=0 a=salB9WdMPIDduBH7JsZfrA==:117 a=salB9WdMPIDduBH7JsZfrA==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=LXJ1KyY7SpB490TPGc8A:9 a=QEXdDO2ut3YA:10 a=6kGIvZw6iX1k4Y-7sg4_:22 X-Auth-id: anZkZWxpc2xlQGNoYXJ0ZXIubmV0 Subject: Re: [PATCH] Don't assume __secure_getenv is available To: Janne Blomqvist , Fortran List , GCC Patches References: <20170427125804.GZ1809@tucnak> <1493319051-25795-1-git-send-email-blomqvist.janne@gmail.com> From: Jerry DeLisle Message-ID: <6e206092-86bd-c0d3-4960-cae262fdbd30@charter.net> Date: Mon, 08 May 2017 17:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00575.txt.bz2 On 05/07/2017 11:37 PM, Janne Blomqvist via fortran wrote: > PING > > On Thu, Apr 27, 2017 at 9:55 PM, Janne Blomqvist > wrote: >> On Thu, Apr 27, 2017 at 9:50 PM, Janne Blomqvist >> wrote: >> [snip] >> >> And on top of that patch this simple typo fix: >> >> diff --git a/libgfortran/runtime/environ.c b/libgfortran/runtime/environ.c >> index 969dcdf..f488e87 100644 >> --- a/libgfortran/runtime/environ.c >> +++ b/libgfortran/runtime/environ.c >> @@ -46,7 +46,7 @@ static char* weak_secure_getenv (const char*) >> char * >> secure_getenv (const char *name) >> { >> -#if SUPPORTS_WEAKREF && defined(HAVE__SECURE_GETENV) >> +#if SUPPORTS_WEAKREF && defined(HAVE___SECURE_GETENV) >> if (weak_secure_getenv) >> return weak_secure_getenv (name); >> #endif >> >> >> >> -- >> Janne Blomqvist > > > Looks Ok to me. I thought you might be waiting for Jakub to reply. Thanks, Jerry