From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D64533858D28 for ; Wed, 25 Jan 2023 23:23:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D64533858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674689009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bDpVgYIOFp23yGBOs23z1oNeMgPJl2Cx53SN6vhrHto=; b=iIVUQPzANzBithQbQHJ9//XCwZ+1LxHe6icM2/jVgAwf/W+5IgtwVyeZS0AzUcpqRI4MSA Nz1SkNOHs77z3oCI2xu1cHB5sd3j3ihqYos/lXkPCKz255tT8IjxhK9T6DZzmGf4/2PMz3 ykwUrkAFUmHEHzLgSDwSWfjXFxxPoGk= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-62-UBv2E8viMXqGZp3ucnfTKw-1; Wed, 25 Jan 2023 18:23:28 -0500 X-MC-Unique: UBv2E8viMXqGZp3ucnfTKw-1 Received: by mail-qt1-f197.google.com with SMTP id j14-20020ac874ce000000b003b6917d0731so27414qtr.4 for ; Wed, 25 Jan 2023 15:23:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bDpVgYIOFp23yGBOs23z1oNeMgPJl2Cx53SN6vhrHto=; b=s6aVEYRvpAe4ItjIIf2m8DPqEtn0j9eN1wKecLkxUm9BPWKi+UNVcp0J1oI/T4Bgx5 M1VxMsCOnxXF2tpn6AoU9IxOWQ6tu58RGnXQr0Z053BviRkijWTgXB4pjHBN15C//hGs Qx9Vgbwoedd4zMjpVSjU9wDWtAdFps9CMGr5D7l8OrAWyUoaJNTpw8tAQP3OBS4dFlaf TwojqFW4kxkPa5yPJR5zlRZzCsZWLyXG/BZA0UxGKtfKkK8nguFjbWhizBEE+Bmam//E VaCDJPZqWUkz1asZObKLv9kuwZd9wLiBMDE2Jsz2rXqNRguG5NTKTqWH1CcewPF+XjJd /jLg== X-Gm-Message-State: AFqh2kqfxk3T9NGYYjdgfQdi3g/h/EEOG5wKAUT95Tvw2U65OiKPTp03 otRsRk/t22YACYTh0UsYHpqp5wJrCuwIZ73Vz4XdUTZyaAeayGkgbqvhpyJcFztmmEAfRKQ6Dtq XLFF6orx8yGzDDKIgpA== X-Received: by 2002:ac8:5243:0:b0:3b6:3130:786e with SMTP id y3-20020ac85243000000b003b63130786emr48641825qtn.13.1674689007806; Wed, 25 Jan 2023 15:23:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXsvTvfxI0lnIm9mEEYQzmCSvwbsuHjzPK4v+t1IZuLaXDhejkzaBROWTqkpGtPMczH0jwYhwQ== X-Received: by 2002:ac8:5243:0:b0:3b6:3130:786e with SMTP id y3-20020ac85243000000b003b63130786emr48641808qtn.13.1674689007574; Wed, 25 Jan 2023 15:23:27 -0800 (PST) Received: from ?IPV6:2607:fea8:a263:f600::fa90? ([2607:fea8:a263:f600::fa90]) by smtp.gmail.com with ESMTPSA id h15-20020a05620a13ef00b006cec8001bf4sm4440977qkl.26.2023.01.25.15.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 15:23:27 -0800 (PST) Message-ID: <6e6ec2ef-c186-0a30-0e08-b2dd6e9fd0c0@redhat.com> Date: Wed, 25 Jan 2023 18:23:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] Add VREL_OTHER for FP unsupported relations. To: Jakub Jelinek Cc: gcc-patches , "hernandez, aldy" , Richard Biener References: <0f6b2db4-8b46-9a1f-3bcf-0ef2e9e2c3e0@redhat.com> <78b6c262-bc01-7b62-34ec-e4565aba96d3@redhat.com> <7a3733d7-8298-7b8a-3df9-97e3340a9e3e@redhat.com> From: Andrew MacLeod In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/23 17:35, Jakub Jelinek wrote: > On Wed, Jan 25, 2023 at 11:12:11AM -0500, Andrew MacLeod via Gcc-patches wrote: >> In GCC13, I don't think there are any uses of the relation oracle outside of >> ranger and range-ops. >> >> So, given that, perhaps the simplest thing to do is bail on all this change, >> and instead simply do the following which also fixes the PR. (im running it >> thru tests as we speak) >> >> >> >> diff --git a/gcc/gimple-range-fold.cc b/gcc/gimple-range-fold.cc >> index 91eb6298254..9c5359a3fc6 100644 >> --- a/gcc/gimple-range-fold.cc >> +++ b/gcc/gimple-range-fold.cc >> @@ -1039,6 +1039,9 @@ fold_using_range::relation_fold_and_or (irange& >> lhs_range, gimple *s, >>    if (!ssa1_dep1 || !ssa1_dep2 || !ssa2_dep1 || !ssa2_dep2) >>      return; >> >> +  if (HONOR_NANS (TREE_TYPE (ssa1_dep1))) >> +    return; >> + >>    // Make sure they are the same dependencies, and detect the order of the >>    // relationship. >>    bool reverse_op2 = true; >> >> > If this works, maybe (does something check if ssa1_dep1 has certain > type (I assume ssa1_dep2 has to have the same) then ssa2_dep{1,2} has that > type too (or uselessly equal to that)? Though, if this spot has both > operands of the comparison, could we for HONOR_NANS case ask frange if > any of them is maybe_nan or known_nan and punt only if anything can be NAN? it bootstraps with no regressions. all the ssa?dep? must have the same type, or the comparisons for similarity are going to fail.  ir requires the same 2 ssa-name in both relational expressions, which means they must all be the same type. At this point we don't actually know ranges.. this is a higher level thing before any queries have happen.   we could query, but I'd punt on that for next release :-)  And think about how applicable it is.  Id like to revisit this entire situation. Andrew > > Jakub >