From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id A85CB38555A4 for ; Tue, 15 Nov 2022 03:30:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A85CB38555A4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oo1-xc2c.google.com with SMTP id g15-20020a4a894f000000b0047f8e899623so1875801ooi.5 for ; Mon, 14 Nov 2022 19:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FNjMzxEcvqNsMvtHHuO6gzCNOqjjrIKXc7pYHwmlK/4=; b=etLjV9PQ7mspD6vRreEUNdKXSJniFEpBtoVufyIXejJ5KfrOMCAj8M2niVCP9JYSN3 nvrsQpPB/JFEcO0PLwymgYLwWfhhTAhfNz/gCNzjQNLohh+Sqcu4gz5CB8oTlChthS28 xVdng3/CJqRH0vXm7Z3YBrsUfnWQeyYFq6ZFnu7P5WPQXvXBAkSXxAu3NDwxDPh8QFhX sQ/TaRft/5DHlPGR/7DuLFMZqPBaEKSg8j+CqnNNwSdq0W9COCh88spjWsOsVc0BqNjs TpNC2fr51dFwKotSpoq+wNhNeu8GZn4a3SPvMGIk7RGEYoI46edWQ/dd+NGJpC2Rsdnh mMvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FNjMzxEcvqNsMvtHHuO6gzCNOqjjrIKXc7pYHwmlK/4=; b=Z1j/+/BDj+wdxYu/KtC0oKNtgYO1CjAL2U4YLRw23jMs17/8xgEh5M4X9fiJBdVnBE 9ZY92iab2/s2Hvdf46nxwxp+cdXiTAPVtdy3hDW4drTtePmz8LZ3lKQ5A9BEhlUuQZAw Mb934JRJ5I07Zs6094D1xTexLlIHRUBxE+4pwkiGNFVBvLR4oinoLuvtjsOV4tmWh/X+ trkBVYbWhzYvEjj6Ln+4rev68qOgABLS52E4iKaohB716tFyPZRcO90yfGEGZxOBgzTp p/CbVSkVdr//9E94zbyIrxpJNYCq0CUDNe4rxCJEAlmgZTGtx4yJOIdZZCr2VEtTvBRe b7sg== X-Gm-Message-State: ANoB5pkbtXWxmnhbvjTDcBe1aux03VGceO8GgbgjkvvdTWG5uZz3LsZc uOEr/F/lcGgKTDlJjq5B8NQ= X-Google-Smtp-Source: AA0mqf6+ny1fXqQZMcwLgh2phY80N/xS+HSM8VraLYe/BXa0+nDGFmzeVYu/TyqHG1OcchOgv9/7nw== X-Received: by 2002:a4a:bb8c:0:b0:49a:5793:2981 with SMTP id h12-20020a4abb8c000000b0049a57932981mr6903928oop.8.1668483055800; Mon, 14 Nov 2022 19:30:55 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id y74-20020a4a454d000000b0044b47bb023fsm4342406ooa.37.2022.11.14.19.30.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Nov 2022 19:30:55 -0800 (PST) Message-ID: <6e8d2e69-58dd-56cc-8f41-26ac8af9573d@gmail.com> Date: Mon, 14 Nov 2022 20:30:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Optimal RVV epilogue logic. Content-Language: en-US To: jiawei , gcc-patches@gcc.gnu.org Cc: kito.cheng@sifive.com, palmer@rivosinc.com, juzhe.zhong@rivai.ai, christoph.muellner@vrull.eu, philipp.tomsich@vrull.eu, wuwei2016@iscas.ac.cn References: <20221114162918.1563116-1-jiawei@iscas.ac.cn> From: Jeff Law In-Reply-To: <20221114162918.1563116-1-jiawei@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/22 09:29, jiawei wrote: > Skip add insn generate if the adjust size equal to zero. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_expand_epilogue): > New if control segement. > > --- > gcc/config/riscv/riscv.cc | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index 02a01ca0b7c..af138db7545 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -5186,24 +5186,26 @@ riscv_expand_epilogue (int style) > } > > /* Get an rtx for STEP1 that we can add to BASE. */ > - rtx adjust = GEN_INT (step1.to_constant ()); > - if (!SMALL_OPERAND (step1.to_constant ())) > + if (step1.to_constant () != 0){ This doesn't follow GCC formatting rules.  The open-curley should go on a new line, intended two spaces further in.  This will (of course) cause other code to need to be reindented as well. Jeff