From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 4ED1E3858CD1 for ; Tue, 21 Nov 2023 20:48:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4ED1E3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4ED1E3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.137.252 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700599741; cv=none; b=EteBaFO/vGopT3aohNKwPyAKcm7oNu+ce1iXftFkpHXu6dhbAFl6IGBOt6ME5E44uANMSFWtmGxBOhY9eoKSr5q0KQFXVIdmVy1QMyy0rvhgUjO5zDII5BzJ40ywbLN02sbsFhsA8GW/iMFsUd+dutuy2v/de7VBNpl/IWJXvw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700599741; c=relaxed/simple; bh=8AEFVLDekGPZdGECosaLplA0/WlUd4PzHOZoPztBN9k=; h=Message-ID:Date:MIME-Version:Subject:From:To; b=sKUR6DGHd9KknTLHXmI5f8r/ANPlEc2oWbE0CUeavEmvZX7iRwU3hzp57KTlLXgxjlxHsW7EObXUc6w/kgTSwn1jxAQ8NyqI/7bYeKoqLcYeps9N5i/Z68pwOiwTYa9kB/UgSgmQStZfwY5BTV73/z+Xl+HZEvs45Sv1wEob2YI= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: 4Ak/dR4pQHifwhbRsLjQvg== X-CSE-MsgGUID: osxpGZOBSkWb1xyHxzdGFA== X-IronPort-AV: E=Sophos;i="6.04,216,1695715200"; d="scan'208";a="23365326" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 21 Nov 2023 12:48:57 -0800 IronPort-SDR: ooSSIgwIZ31cZGAJDPk6LXfvaznRbKLfucVr1sxvUEJ+HjO8i5up2aYDH//VnY0dund1MzXPVS xsYwpqD1bir5suH2Yb2PVnlAI2OVI2aSZcXTFg3NQecAMGa4orsJXvQ9SOR3Q+bGW7ALJ+QXwW KJqub3B/eOlAr/f7s8Dit2dA8s+h+jYpYN4rHyRYoL0Y3yH+OK2C0yfg00H+5k7f17ur5K5eRn Tsjbdr282DFAhGeoYwNyU3peQpzbDhv7Yp45kIxtIkruvr9I6F6zhJodmBaz1+v0f+JIMnZdcz 11Y= Message-ID: <6eac92d0-ee67-2979-7ba3-abf08be2d2a7@codesourcery.com> Date: Tue, 21 Nov 2023 13:48:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 3/3] OpenMP: Use enumerators for names of trait-sets and traits Content-Language: en-US From: Sandra Loosemore To: CC: , , Julian Brown References: <20231119092151.1690294-1-sandra@codesourcery.com> <20231119092151.1690294-4-sandra@codesourcery.com> In-Reply-To: <20231119092151.1690294-4-sandra@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-14.mgc.mentorg.com (147.34.90.214) To svr-orw-mbx-13.mgc.mentorg.com (147.34.90.213) X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/19/23 02:21, Sandra Loosemore wrote: > This patch introduces enumerators to represent trait-set names and > trait names, which makes it easier to use tables to control other > behavior and for switch statements to dispatch on the tags. The tags > are stored in the same place in the TREE_LIST structure (OMP_TSS_ID or > OMP_TS_ID) and are encoded there as integer constants. > > This patch has only been lightly tested and still has at least one bug > that causes an ICE. :-( Update: I've tracked down the ICE to me having introduced an incorrect variable initialization in omp_context_compute_score. I'm now looking at fixing interfaces to avoid the separate bug in omp_mark_declare_variant that Julian reported, and I'll post a revised part 3 in the next day or two. -Sandra