From: Jason Merrill <jason@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c++: Fix value-init crash in template [PR93676]
Date: Thu, 13 Feb 2020 23:24:00 -0000 [thread overview]
Message-ID: <6eb452b2-c291-8a14-9e33-303a789db065@redhat.com> (raw)
In-Reply-To: <20200211195459.358172-1-polacek@redhat.com>
On 2/11/20 8:54 PM, Marek Polacek wrote:
> Since <https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00556.html> we
> attempt to value-initialize in build_vec_init even when there's no
> initializer but the type has a constexpr default constructor. But
> build_value_init doesn't work in templates, so I think let's avoid
> this scenario; we'll go to the normal build_aggr_init path then.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk and branches?
>
> PR c++/93676 - value-init crash in template.
> * init.c (build_vec_init): Don't perform value-init in a template.
Hmm, we really shouldn't even be calling build_vec_init in a template,
that builds up a lot of garbage that we'll throw away at the end of
build_new.
Jason
next prev parent reply other threads:[~2020-02-13 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 19:55 Marek Polacek
2020-02-13 23:24 ` Jason Merrill [this message]
2020-02-19 21:15 ` [PATCH v2] " Marek Polacek
2020-02-20 0:13 ` Jason Merrill
2020-02-20 16:52 ` [PATCH v3] " Marek Polacek
2020-02-24 22:16 ` Jason Merrill
2020-02-25 17:53 ` [PATCH v4] " Marek Polacek
2020-02-25 18:27 ` Jason Merrill
2020-02-25 18:55 ` [PATCH v5] " Marek Polacek
2020-02-25 19:34 ` Marek Polacek
2020-02-26 4:26 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb452b2-c291-8a14-9e33-303a789db065@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).