From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc29.google.com (mail-oo1-xc29.google.com [IPv6:2607:f8b0:4864:20::c29]) by sourceware.org (Postfix) with ESMTPS id 019A53858D33 for ; Sun, 19 Nov 2023 15:12:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 019A53858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 019A53858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c29 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700406742; cv=none; b=Ed4LPmfyErvyUrzY7WWYd0tJTtPBLk5yVTnhZ0BbLxdSe8UVei9zXjCNt4jqRnbuC5GfiCHWHz0mPw08KUB9fjjutjW4qqrhMPVfqH6fFsgFtLf5FjzO7sZoGZkQ4pG3Tg2bscJ4PAuO+weA/SbxQjIv1CRRL4auYLKzYhzYATA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700406742; c=relaxed/simple; bh=e8vGDMiYqwhmYEbzF66pUmgVfWMDADgAV2Bn36pw0sQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=k9hWIduJFvC9/+VxzCgBNYuD0KM85UyRhdLGAHd5nxj49OKoCxkXTTD95TZrjDnEUVMEKs644hz/B8AlSsADjXhYQVHJjoLcJ3qoz2rjxU1RXe0P4E380H2P7VFgs18qbJM0vyO+ibZG8sq9WNKAqpKYXecyvm2gCl38xIcLUHs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc29.google.com with SMTP id 006d021491bc7-5845a94dae1so1801470eaf.0 for ; Sun, 19 Nov 2023 07:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700406740; x=1701011540; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/qQvKbV9XopLqI4Ox7KQsb1nxvXU/w+vxtoqcpBr4E4=; b=XBjTi8B5uiOVozIHrGUWaXGxOoutM0xXqLeXk35FO26Ou6d035wghAfbSN4/iSF0JQ oBIHfjf8L2rL7BvDNuFDpP14XuueCxDKO3D/4ENgD2ESD7v8S4hlimPCUIcU8gxP18RI bcaEb0qNNJ5eXDVsfwpHgDlCi60PRFev730jPC7F8XO+M8h0u7EdqlEWP9GVuFb9fk5S njXlJAFOTGNJ8BJ78X4wMskasZVzF8YZPD0ZLQOZQgw5grCI5roHRwyMzvFh3qUFW5Ei +ZGlDya6USzmkhkVyNdy2AMMtUlKidcAbKI18IDQl8a0JIwXgniwoFojvKS99sk/1/oE GJnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700406740; x=1701011540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/qQvKbV9XopLqI4Ox7KQsb1nxvXU/w+vxtoqcpBr4E4=; b=MNIoLqj+quiBmaHB1EosAgdctHU/BFNWVHijHmrDHgk6Dro+rz+oAy+YqIJ8gC3kEL 0ZZ7dB52sYktIoTDm0+figMqbNiA7JfGAuK7upiZEpPlg+pylpuuwgmxz/yIt8AdsWjG 4OoyoxtYq3xFHvixHbbl2ykIs5yFojxFVsqZFLY+kc0UVeDP9xjsXvygVJHHj87DJKtM LjxVTiHW8f4rzvp2fIvDXXL2XGnIh4CLzcWgOTAOJdNTLTmqUdJ3L/1vevSCbjxZQHXl K2o1hOAEDyX2ZtWCfA3ULK5dGAAz5/H1eMdSQqkofkZKIppXzDI+cFU3nzNKRucSXD4y qJ+g== X-Gm-Message-State: AOJu0YxzLtpeTLypkAjAfccdde4QNZ2mIw/smr3rsRPwYGibeB0WM5uV eBUkBRS5YDWrezYQWiPevok= X-Google-Smtp-Source: AGHT+IHIQidxob3iKqXHuSBwfcwd3Zp2LzK7YTV/TaZxzAZtrj+xM0zGnxxOdEryw79nGRpmOXLKrQ== X-Received: by 2002:a4a:ee08:0:b0:586:bf08:fa28 with SMTP id bd8-20020a4aee08000000b00586bf08fa28mr7002362oob.3.1700406740164; Sun, 19 Nov 2023 07:12:20 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id c17-20020a4ad8d1000000b0058a0809ea25sm1069944oov.21.2023.11.19.07.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 07:12:19 -0800 (PST) Message-ID: <6f1516e7-f4be-4e13-b04c-8b5c31cae4f7@gmail.com> Date: Sun, 19 Nov 2023 08:12:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] testsuite: scev: expect fail on ilp32 Content-Language: en-US To: Alexandre Oliva , gcc-patches@gcc.gnu.org Cc: Richard Biener , Rainer Orth , Mike Stump References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/19/23 00:30, Alexandre Oliva wrote: > > I've recently patched scev-3.c and scev-5.c because it only passed by > accident on ia32. It also fails on some (but not all) arm-eabi > variants. It seems hard to characterize the conditions in which the > optimization is supposed to pass, but expecting them to fail on ilp32 > targets, though probably a little excessive and possibly noisy, is not > quite as alarming as getting a fail in test reports, so I propose > changing the xfail marker from ia32 to ilp32. > > I'm also proposing to add a similar marker to scev-4.c. Though it > doesn't appear to be failing for me, I've got reports that suggest it > still does for others, and it certainly did for us as well. > > Regstrapped on x86_64-linux-gnu, also tested on arm-eabi with default > cpu on trunk, and with tms570 on gcc-13. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.dg/tree-ssa/scev-3.c: xfail on all ilp32 targets, > though some of these do pass. > * gcc.dg/tree-ssa/scev-4.c: Likewise. > * gcc.dg/tree-ssa/scev-5.c: Likewise. OK. Though hopefully someone will figure out what properties actually cause the differences so that we can do the right thing without the noisy XPASS at some point. jeff