public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H'
Date: Sun, 22 Oct 2023 19:54:30 -0600	[thread overview]
Message-ID: <6f25c003-281a-4372-8fc1-f160db12a77d@gmail.com> (raw)
In-Reply-To: <6e2f6992-133a-4e68-82cc-24388e387523@irq.a4lg.com>



On 10/21/23 19:33, Tsukasa OI wrote:

> 
> Hmm, I generally agree with your opinion and I made a board file for
> DejaGnu (running qemu-riscv64) to run "make check-gcc
> RUNTESTFLAGS='--target_board=riscv-sim riscv.exp'" because it already
> contains many execute tests (and annoys me if I don't do that).
> 
> What I'm not sure is, what kind of regression tests we need?
> 
> (In my mind)
> Level 1: Make nearly empty program with specific -march (and optionally
>           -mabi?) and make sure that it works.
> Level 2: Make a program with inline assembly and execute tests with
>           specific configurations (with specific -march and -mabi)
>           [I'm not sure how to write **and optionally execute tests**]
> 
> I would like to hear your thoughts.
So I don't think we need to do a large matrix of extensions or anything 
like that.  Whatever config you usually build should be sufficient.

What most folks do is a make -k check before/after their patch and 
compare the results.  That's the standard.

If you change a target independent file, then the standard would be to 
bootstrap and regression test on x86 or similar primary architecture.

Jeff

      reply	other threads:[~2023-10-23  1:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-21  5:32 Tsukasa OI
2023-10-21 18:04 ` Jeff Law
2023-10-22  1:33   ` Tsukasa OI
2023-10-23  1:54     ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f25c003-281a-4372-8fc1-f160db12a77d@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=research_trasio@irq.a4lg.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).