From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 988F53858D39 for ; Mon, 23 Oct 2023 01:54:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 988F53858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 988F53858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698026076; cv=none; b=gnXzILkpZCGnRg2+BdJ+RO24+wcOLKoLrCUS6295YXV19WtRT4XwmwCY99sAh3je4LhjDU1oIOt3URtYnHWlL9IBmg/2LDROoaYxFP9WIL1m58qJJLrNy/LqhedTorbLJbKv6kVpEutvgds8ltBlLUUutszJs3VHT44QwGsaypM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698026076; c=relaxed/simple; bh=9QPOGM90IbFVDBMyS+gegY23BDxloZvRJYmUYExROl0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TKMqwO7Dd1U2oT86IObznvG1YSTqyde0A62+BnM9iYoDfiMIaaBqkyIlPJ2DxDeT83K95ekv48sFNwf3eY6MjwKJXtUCbnETZ9wGUGh+3/UhCSiBZoMgDzkTF0lgtXzQYiOnIvaYpjub6F04cQ6IQhE5Ck+isSqm9XKLBZcJLdw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1c9b95943beso23346395ad.1 for ; Sun, 22 Oct 2023 18:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698026074; x=1698630874; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=umgyomBtS4AYxOVmZcHfGh24aWMMkKBMnius9+IiySE=; b=W8iLljem9bx7Dn4n9tH3MYAuHzPzf88D+LBQXcLT7BHBUSqiIml2Kr71IST6cfmCFA PQNgW2/5xfKdNUw8SmTZbEPSfRAH8SkJMn2rq+hjXBtrMG5WB2fVnmwN+pefPqkn7Zt7 omgDrFLkGrHVqtntvSwX0nsP92JwexX6665NJOVv+aAeNIIDlGEtYDiQLfq2k4TKfkDi vMHfg5eIi+biAICrraIzxKazCsHqR8PcqC2vWjykkGYI4NT2WhkBLQOGSMVlq4GrVt7G Tf3SBcOtvQFcivAJAzbVCN22gMTQW3YsS34cgb5v4wLclRNjaidDRbaw2Tku8FqDvddm Qftg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698026074; x=1698630874; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=umgyomBtS4AYxOVmZcHfGh24aWMMkKBMnius9+IiySE=; b=rQsYR40HKYImFfy/HxFG4H9WHraiRgfSdxZHQoVeSbNiSdSQwqoSqhv+f7LHTbqXmC f8FBC9aPRrqSJXCW+yeJg7B7SveToFgQQMY4E/95loN7Jk2qQRhXJUQ15cGH/+bfdXd9 nIlm/OHOd7W20RfNixtXgYeg3OUuSuUefu4oJ7yiB/yuY6sE49n7yf8bl3RZKN+N4XC5 ze2UEj/wW/4NyAusP15pp21D4bU1KRm9U5QBqHhdyzZyBcVTZQTghXKL4DOmlwbAQ7v4 gX/HNcolt36O3v9Xkusarj06b4xfYZsgTvE5KS2daCdVO+MQwoUh8jGEGebXzALs4NvN 7WMg== X-Gm-Message-State: AOJu0Yx6z6g8TDS17s3MLt+hZYaW1cyHaXRw8n5n5ivcGrBbeRSWjv9Y jlapAfHfXnJyBNra8g3Uk0csN0ckZwk= X-Google-Smtp-Source: AGHT+IHHyshab6ZYORVhn+HaaWFFJm5zw2DziUulkXIhUeODcYZbvupAFbgZhDrHTzFDDfJWHD6Nxg== X-Received: by 2002:a17:902:db12:b0:1ca:16e8:1b47 with SMTP id m18-20020a170902db1200b001ca16e81b47mr9673838plx.1.1698026074336; Sun, 22 Oct 2023 18:54:34 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id jj5-20020a170903048500b001ca21c8abf7sm4966619plb.188.2023.10.22.18.54.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Oct 2023 18:54:33 -0700 (PDT) Message-ID: <6f25c003-281a-4372-8fc1-f160db12a77d@gmail.com> Date: Sun, 22 Oct 2023 19:54:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Prohibit combination of 'E' and 'H' Content-Language: en-US To: Tsukasa OI , GCC Patches References: <92fad87801003eaa4cf9f47a1ab8d6e6f015ed12.1697866371.git.research_trasio@irq.a4lg.com> <6e2f6992-133a-4e68-82cc-24388e387523@irq.a4lg.com> From: Jeff Law In-Reply-To: <6e2f6992-133a-4e68-82cc-24388e387523@irq.a4lg.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/21/23 19:33, Tsukasa OI wrote: > > Hmm, I generally agree with your opinion and I made a board file for > DejaGnu (running qemu-riscv64) to run "make check-gcc > RUNTESTFLAGS='--target_board=riscv-sim riscv.exp'" because it already > contains many execute tests (and annoys me if I don't do that). > > What I'm not sure is, what kind of regression tests we need? > > (In my mind) > Level 1: Make nearly empty program with specific -march (and optionally > -mabi?) and make sure that it works. > Level 2: Make a program with inline assembly and execute tests with > specific configurations (with specific -march and -mabi) > [I'm not sure how to write **and optionally execute tests**] > > I would like to hear your thoughts. So I don't think we need to do a large matrix of extensions or anything like that. Whatever config you usually build should be sufficient. What most folks do is a make -k check before/after their patch and compare the results. That's the standard. If you change a target independent file, then the standard would be to bootstrap and regression test on x86 or similar primary architecture. Jeff