[PATCH][pushed] docs: document threader-mode param

[PATCH][pushed] docs: document threader-mode param

[Martin Liška]

Hi.

Pushing as obvious.

Martin

gcc/ChangeLog:

	* doc/invoke.texi: Document threader-mode param.
---
  gcc/doc/invoke.texi | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 65bb9981f02..4efc8b757ec 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -13421,6 +13421,9 @@ Setting to 0 disables the analysis completely.
  @item modref-max-escape-points
  Specifies the maximum number of escape points tracked by modref per SSA-name.
  
+@item threader-mode
+Specifies the mode the backwards threader should run in.
+
  @item profile-func-internal-id
  A parameter to control whether to use function internal id in profile
  database lookup. If the value is 0, the compiler uses an id that
-- 
2.32.0

Re: [PATCH][pushed] docs: document threader-mode param

[Aldy Hernandez]

On 8/4/21 9:49 AM, Martin Liška wrote:
> Hi.
> 
> Pushing as obvious.
> 
> Martin
> 
> gcc/ChangeLog:
> 
>      * doc/invoke.texi: Document threader-mode param.
> ---
>   gcc/doc/invoke.texi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index 65bb9981f02..4efc8b757ec 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -13421,6 +13421,9 @@ Setting to 0 disables the analysis completely.
>   @item modref-max-escape-points
>   Specifies the maximum number of escape points tracked by modref per 
> SSA-name.
> 
> +@item threader-mode
> +Specifies the mode the backwards threader should run in.
> +

This is slated to be removed sometime in the next few weeks, thus why I 
didn't document it.

In the future, is there a preferred way to add internal --param's not 
for public consumption?  I've run into the same problem with 
--param=threader-iterative, with folks adding PRs for an undocumented 
internal construct.

Sorry to have created work for you.

Aldy

Re: [PATCH][pushed] docs: document threader-mode param

[Martin Liška]

On 8/4/21 10:54 AM, Aldy Hernandez wrote:
> On 8/4/21 9:49 AM, Martin Liška wrote:
>> Hi.
>>
>> Pushing as obvious.
>>
>> Martin
>>
>> gcc/ChangeLog:
>>
>>      * doc/invoke.texi: Document threader-mode param.
>> ---
>>   gcc/doc/invoke.texi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
>> index 65bb9981f02..4efc8b757ec 100644
>> --- a/gcc/doc/invoke.texi
>> +++ b/gcc/doc/invoke.texi
>> @@ -13421,6 +13421,9 @@ Setting to 0 disables the analysis completely.
>>   @item modref-max-escape-points
>>   Specifies the maximum number of escape points tracked by modref per SSA-name.
>>
>> +@item threader-mode
>> +Specifies the mode the backwards threader should run in.
>> +
> 
> This is slated to be removed sometime in the next few weeks, thus why I didn't document it.

Oh, I see.

> 
> In the future, is there a preferred way to add internal --param's not for public consumption?

Params are internal by design and can be liberally modifies as we want. That's different from options which
should be treated conservativelly.

> I've run into the same problem with --param=threader-iterative, with folks adding PRs for an undocumented internal construct.
> 
> Sorry to have created work for you.

That's fine!
Martin

> 
> Aldy
>