From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 48A38385842F for ; Wed, 4 Aug 2021 08:59:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48A38385842F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 31500218BB; Wed, 4 Aug 2021 08:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628067570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aaKOWeOcg5Jee5GYdkxvd1lm+1+WLPkzfLT1bLmlJSE=; b=mGoKOTtowTe1sIadaVFjB64dGlTjIcmKkPPSea/yKL3syFeI3xVGk3RXMNDXYJmuNyGzUw M2sJ7uKlwsZ4/q+UHJ4othYke49W/T1I9hw+Rimy9hlqgIDlfJvAyIJ9FVUKV7EGrLP2m9 8e2U0VmySfSsjpy8aNcAc9dNy96h2Nw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628067570; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aaKOWeOcg5Jee5GYdkxvd1lm+1+WLPkzfLT1bLmlJSE=; b=j1EvWww5pN3JLkakEr5BxogHWIc6Yv+nh46KXVM2g8e6F8JRkJQi3Ws23pKUtGJXhY5lmH moLStDkbFgpC7ZAg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 14ED1136DD; Wed, 4 Aug 2021 08:59:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id ZrcsBPJWCmGgYwAAGKfGzw (envelope-from ); Wed, 04 Aug 2021 08:59:30 +0000 Subject: Re: [PATCH][pushed] docs: document threader-mode param To: Aldy Hernandez , gcc-patches@gcc.gnu.org References: <6ea56829-8e81-e586-9893-3c141420eb05@redhat.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <6f6fa720-0d31-e417-afc2-e1da4298b7c5@suse.cz> Date: Wed, 4 Aug 2021 10:59:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6ea56829-8e81-e586-9893-3c141420eb05@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 08:59:33 -0000 On 8/4/21 10:54 AM, Aldy Hernandez wrote: > On 8/4/21 9:49 AM, Martin Liška wrote: >> Hi. >> >> Pushing as obvious. >> >> Martin >> >> gcc/ChangeLog: >> >>      * doc/invoke.texi: Document threader-mode param. >> --- >>   gcc/doc/invoke.texi | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi >> index 65bb9981f02..4efc8b757ec 100644 >> --- a/gcc/doc/invoke.texi >> +++ b/gcc/doc/invoke.texi >> @@ -13421,6 +13421,9 @@ Setting to 0 disables the analysis completely. >>   @item modref-max-escape-points >>   Specifies the maximum number of escape points tracked by modref per SSA-name. >> >> +@item threader-mode >> +Specifies the mode the backwards threader should run in. >> + > > This is slated to be removed sometime in the next few weeks, thus why I didn't document it. Oh, I see. > > In the future, is there a preferred way to add internal --param's not for public consumption? Params are internal by design and can be liberally modifies as we want. That's different from options which should be treated conservativelly. > I've run into the same problem with --param=threader-iterative, with folks adding PRs for an undocumented internal construct. > > Sorry to have created work for you. That's fine! Martin > > Aldy >