public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Carlini <paolo.carlini@oracle.com>
To: Christophe Lyon <christophe.lyon@linaro.org>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Jason Merrill <jason@redhat.com>
Subject: Re: [C++ Patch] Fix four more locations
Date: Tue, 08 Jan 2019 11:49:00 -0000	[thread overview]
Message-ID: <6f8e9d0e-e135-57ce-8efe-e504b0673ce1@oracle.com> (raw)
In-Reply-To: <CAKdteOYKBUs+bk_x83bX7vMk-wmrpoPDihoHw5zCFsGQH66ELw@mail.gmail.com>

Hi,

On 08/01/19 11:24, Christophe Lyon wrote:
> On Mon, 7 Jan 2019 at 18:08, Paolo Carlini <paolo.carlini@oracle.com> wrote:
>> Hi,
>>
>> should be straightforward material. Tested x86_64-linux, as usual.
>>
>> Thanks, Paolo.
>>
>> /////////////////////
>>
> Hi,
>
> The new g++.dg/diagnostic/thread1.C passes on aarch64, but fails on arm:
> FAIL: g++.dg/diagnostic/thread1.C  -std=c++14  (test for errors, line 13)
> FAIL: g++.dg/diagnostic/thread1.C  -std=c++14 (test for excess errors)
> FAIL: g++.dg/diagnostic/thread1.C  -std=c++17  (test for errors, line 13)
> FAIL: g++.dg/diagnostic/thread1.C  -std=c++17 (test for excess errors)
>
> the logs say:
> /gcc/testsuite/g++.dg/diagnostic/thread1.C:13:12: error: non-local
> variable 's' declared '__thread' needs dynamic initialization
>
> I don't know why the error message does not match?

Evidently on some targets that variable also needs dynamic 
initialization, the issue isn't just that it has a non-trivial 
destructor. Thus, I'm simply going to shorten by one word the expected 
string.

Thanks, Paolo.

      reply	other threads:[~2019-01-08 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 17:08 Paolo Carlini
2019-01-07 19:21 ` Jason Merrill
2019-01-08 10:25 ` Christophe Lyon
2019-01-08 11:49   ` Paolo Carlini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f8e9d0e-e135-57ce-8efe-e504b0673ce1@oracle.com \
    --to=paolo.carlini@oracle.com \
    --cc=christophe.lyon@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).