From: Nathan Sidwell <nathan@acm.org>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] make RTL/TREE/IPA dump kind an index
Date: Wed, 10 May 2017 11:40:00 -0000 [thread overview]
Message-ID: <6fb48593-224d-fee9-3089-36d519b493c9@acm.org> (raw)
In-Reply-To: <CAFiYyc3uSB1KqScBrftsNQ_fet09Mjm_tP6MBUJxOw_qcpd0TQ@mail.gmail.com>
On 05/10/2017 05:05 AM, Richard Biener wrote:
> On Tue, May 9, 2017 at 9:00 PM, Nathan Sidwell <nathan@acm.org> wrote:
> +
> +#define TDF_ADDRESS (1 << 3) /* dump node addresses */
>
> this leaves 1 << 2 unused.
Yes, that was intentional (though I suspect my note about it was
hidden). As you say, I expect further cleanup and didn't want
gratuitous churn. I'll add a comment about bit 2 being free.
> Otherwise looks like a great cleanup. You might want to coordinate with
> Martin a bit here. It also looks like with this we can start re-using
> bits when they are restricted to one TDF_KIND.
Indeed, we coordinated a bit yesterday. Thanks for review!
nathan
--
Nathan Sidwell
next prev parent reply other threads:[~2017-05-10 11:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 19:33 Nathan Sidwell
2017-05-10 9:10 ` Richard Biener
2017-05-10 11:40 ` Nathan Sidwell [this message]
2017-05-11 12:37 ` Rainer Orth
2017-05-11 12:44 ` Nathan Sidwell
2017-05-11 13:14 ` Nathan Sidwell
2017-05-11 22:58 ` Bernhard Reutner-Fischer
2017-05-11 23:10 ` Rainer Orth
2017-05-11 23:18 ` Bernhard Reutner-Fischer
2017-05-13 8:49 ` Bernhard Reutner-Fischer
2017-05-14 7:20 ` Nathan Sidwell
2017-05-17 12:25 ` Richard Biener
2017-05-12 0:30 ` Nathan Sidwell
2017-05-12 9:24 ` Rainer Orth
2017-05-12 0:59 ` Nathan Sidwell
2017-05-12 6:11 ` Bernhard Reutner-Fischer
2017-05-11 13:49 Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb48593-224d-fee9-3089-36d519b493c9@acm.org \
--to=nathan@acm.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).