From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 722383857836 for ; Thu, 13 May 2021 13:43:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 722383857836 Received: by mail-pg1-x534.google.com with SMTP id j12so15335131pgh.7 for ; Thu, 13 May 2021 06:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+LnD9ksV6G7m2Wd3PLooRYwXvWDeCv/eT2y/VptlN1Y=; b=fHSXHY61xqJ0ZuADklKNcz4ccT4zrqP6nwx5IJzq9bsnlmej9G1Ueg6P5W5rji/lFF dKQuNwUOWOds5gsZ6gAlyHo3XsYA26gCa4F0NgduxsrA+lJDqDRga0lK6ewwo7F1QGQ2 0SWG0OKB8NQAVJL8eynI34zm8B64gxiuCIg1niO6fJydeS+N2EsEJvUE49TIoLG77SOX OIob5MsN9G45Ys8LvVrg4jmQ0rTigsHd+3pHfVWwoI9qqWX01c2ZcYWVuiCxK852fzc7 ae+LHIdQNSMiRVOqujy7EJlo0loK7oC6yX0MBquQIDg50svHZgLILRrqImnafPGVT92l dCBA== X-Gm-Message-State: AOAM533vYxE5b9UPpWP7B4zyUGlTU02fYb8wdV8DSfbrSWWDXpNDg2co hU2wL1XfSu4Mb2JkEXnNYtJF8gAzOuBc1A== X-Google-Smtp-Source: ABdhPJwnM4ShP3TxD+Fdo83x5qAbijtHHc9yStkhhBd7dqnpMWNGCHZYNtH6LRyp//DDY6yZs8KP6A== X-Received: by 2002:a63:ad42:: with SMTP id y2mr41711072pgo.187.1620913419323; Thu, 13 May 2021 06:43:39 -0700 (PDT) Received: from [192.168.1.2] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id l62sm2150592pfl.88.2021.05.13.06.43.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 May 2021 06:43:39 -0700 (PDT) Subject: Re: [PATCH] Remove unused variable. To: =?UTF-8?Q?Martin_Li=c5=a1ka?= , gcc-patches@gcc.gnu.org References: <81be254c-5f4a-1bb5-3ec3-fdbc539590e9@suse.cz> From: Jeff Law Message-ID: <6fb5767b-de55-5de6-fc41-8b09da04078a@gmail.com> Date: Thu, 13 May 2021 07:43:37 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <81be254c-5f4a-1bb5-3ec3-fdbc539590e9@suse.cz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 13:43:41 -0000 On 5/13/2021 3:06 AM, Martin Liška wrote: > Addresses the following clang warning: > gcc/tree-ssa-dom.c:652:33: warning: private field 'm_simplifier' is > not used [-Wunused-private-field] > > Ready for master? > Thanks > > gcc/ChangeLog: > >     * tree-ssa-dom.c: Remove m_simplifier. I wonder if Aldy's refactor accidentally dropped the ephemeral simplifications based on the threading path equivalences which is what I think this is supposed to be supporting.  Given that the refactor didn't cause any regressions, if that capability did get dropped, it couldn't be too important anymore. OK for the trunk, Jeff