public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH 3/5] xtensa: Fix instruction counting regarding block move expansion
Date: Fri, 13 May 2022 22:29:22 +0900	[thread overview]
Message-ID: <6fc7ba62-f570-ec94-eab7-43f8da2d56a9@yahoo.co.jp> (raw)

This patch makes counting the number of instructions of the remainder
(modulo 4) part more accurate.

gcc/ChangeLog:

	* gcc/config/xtensa/xtensa.cc (xtensa_expand_block_move):
	Make instruction counting more accurate, and simplify emitting insns.
---
  gcc/config/xtensa/xtensa.cc | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc
index c5518ff9549..d2aabf38339 100644
--- a/gcc/config/xtensa/xtensa.cc
+++ b/gcc/config/xtensa/xtensa.cc
@@ -1313,7 +1313,7 @@ xtensa_expand_block_move (rtx *operands)
    move_ratio = 4;
    if (optimize > 2)
      move_ratio = LARGEST_MOVE_RATIO;
-  num_pieces = (bytes / align) + (bytes % align); /* Close enough 
anyway.  */
+  num_pieces = (bytes / align) + ((bytes % align + 1) / 2);
    if (num_pieces > move_ratio)
      return 0;

@@ -1350,7 +1350,7 @@ xtensa_expand_block_move (rtx *operands)
  	  temp[next] = gen_reg_rtx (mode[next]);

  	  x = adjust_address (src_mem, mode[next], offset_ld);
-	  emit_insn (gen_rtx_SET (temp[next], x));
+	  emit_move_insn (temp[next], x);

  	  offset_ld += next_amount;
  	  bytes -= next_amount;
@@ -1360,9 +1360,9 @@ xtensa_expand_block_move (rtx *operands)
        if (active[phase])
  	{
  	  active[phase] = false;
-	
+
  	  x = adjust_address (dst_mem, mode[phase], offset_st);
-	  emit_insn (gen_rtx_SET (x, temp[phase]));
+	  emit_move_insn (x, temp[phase]);

  	  offset_st += amount[phase];
  	}
-- 
2.20.1

             reply	other threads:[~2022-05-13 13:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-13 13:29 Takayuki 'January June' Suwa [this message]
2022-05-26 16:44 ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fc7ba62-f570-ec94-eab7-43f8da2d56a9@yahoo.co.jp \
    --to=jjsuwa_sys3175@yahoo.co.jp \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).