From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B10943858D28 for ; Tue, 3 Oct 2023 14:31:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B10943858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696343495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=iUV9i0rlXGb8cPduN4it2J8RT5qhnHqR7gjeF92chMA=; b=EzgQ1ZnKcnuhdvbmBdtz4/fpz4IP84d3/ydcDpy3yZsXU2U9MS7chUzmNKKNGyHU88O2NK dDIqyUIr7qsekU0HutPnqA/YUVgBZwb18VoocYjWc7WjFolj5hJwzWUscyv3+vivhJkdeo QFWSi5Njh1PufX3n/ewtNtt5cWgJILQ= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-_OOTEFmENMSQYP-WxAmEBA-1; Tue, 03 Oct 2023 10:31:33 -0400 X-MC-Unique: _OOTEFmENMSQYP-WxAmEBA-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-419754aaa41so10243561cf.2 for ; Tue, 03 Oct 2023 07:31:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696343492; x=1696948292; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2ha3eScDbJYsJJI+wMo4Z/iEu1lHya9MxQg/5fdYbwg=; b=gdpmcUQZfRIKvLT03x8WJwqXVoT5oPnOhsH3xAiUHK+CiS4IU8zf/5QrRZ9avlIidX BCwG5rskBgHpk4FOUja0v5JJxD/eGzXbHmUZrB6VTNyN47hdkCInhxqTXJjW+3XLU3Ru kperZDJRLgKdJQ65CDjPmO3DH91lnwqyuiCJuHH4TKQ+lFu9TuY/ACkRxx7VnxSU8kZ+ n8gJPMiHJ89OcZnJi618qX33DcAFK6uX+BCe556zfN1lG5nPme1dAxclSkZtV2GEFUpR i32WVwYr6XIua29Iz8zqNkSGrh1/kxOWkmB6khoVSBpZDUotqAEb3TbJKny3AhpnDwVH vGBA== X-Gm-Message-State: AOJu0YznJ08lTWC3gLhBj2UgHAYB4A+JsIQy/TfSV6Si2y5R3Q0K4p8e X8J/H2I5XAbmp6bqPSiPyuTYWpeuqyiwgHCPd5xjjk/wLgy5+s+kr9+IVLmBtj17+1gFO31xEzX BIlp9KJYWTaisPRBs7B0oXhidOPsIjxLieNDkY0fQFM6qSu8etjjI3njdkiSwfDXHBc1RTA1CVT yTSQ== X-Received: by 2002:ac8:7c50:0:b0:410:9836:8066 with SMTP id o16-20020ac87c50000000b0041098368066mr16645762qtv.43.1696343492410; Tue, 03 Oct 2023 07:31:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGMo+DOdihWLw0BRPGJvD4k7sTrHf5T47x9W7zzUOkkZVdLG30RgsOF1eQnUb31pDqCjXk2Lw== X-Received: by 2002:ac8:7c50:0:b0:410:9836:8066 with SMTP id o16-20020ac87c50000000b0041098368066mr16645732qtv.43.1696343491954; Tue, 03 Oct 2023 07:31:31 -0700 (PDT) Received: from [192.168.0.174] ([104.219.124.252]) by smtp.gmail.com with ESMTPSA id x16-20020ac87310000000b004181aa90b46sm482804qto.89.2023.10.03.07.31.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 07:31:31 -0700 (PDT) Message-ID: <6ff7d585-b793-a586-efe5-27874242742f@redhat.com> Date: Tue, 3 Oct 2023 10:31:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: gcc-patches From: Andrew MacLeod Subject: [COMMITTED] Return TRUE only when a global value is updated. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------5OScnsIkFz6DWjNgHnQ4MTJv" Content-Language: en-US X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------5OScnsIkFz6DWjNgHnQ4MTJv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit set_range_info should return TRUE only when it sets a new value. It was currently returning true whenever it set a value, whether it was different or not. With this change,  VRP no longer overwrites global ranges DOM has set.  2 testcases needed adjusting that were expecting VRP2 to set a range but turns out it was really being set in DOM2.   Instead they check for the range in the final listing... Bootstrapped on  x86_64-pc-linux-gnu with no regressions. Pushed. Andrew --------------5OScnsIkFz6DWjNgHnQ4MTJv Content-Type: text/x-patch; charset=UTF-8; name="0001-Return-TRUE-only-when-a-global-value-is-updated.patch" Content-Disposition: attachment; filename*0="0001-Return-TRUE-only-when-a-global-value-is-updated.patch" Content-Transfer-Encoding: base64 RnJvbSBkYWU1ZGUyYTIzNTNiOTI4Y2M3MDk5YTc4ZDg4YTQwNDczYWJlZmQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4K RGF0ZTogV2VkLCAyNyBTZXAgMjAyMyAxMjozNDoxNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMS81 XSBSZXR1cm4gVFJVRSBvbmx5IHdoZW4gYSBnbG9iYWwgdmFsdWUgaXMgdXBkYXRlZC4KCnNldF9y YW5nZV9pbmZvIHNob3VsZCByZXR1cm4gVFJVRSBvbmx5IHdoZW4gaXQgc2V0cyBhIG5ldyB2YWx1 ZS4gIFZSUCBubwpsb25nZXIgb3ZlcndyaXRlcyBnbG9iYWwgcmFuZ2VzIERPTSBoYXMgc2V0LiAg Q2hlY2sgZm9yIHJhbmdlcyBpbiB0aGUKZmluYWwgbGlzdGluZy4KCglnY2MvCgkqIHRyZWUtc3Nh bmFtZXMuY2MgKHNldF9yYW5nZV9pbmZvKTogUmV0dXJuIHRydWUgb25seSBpZiB0aGUKCWN1cnJl bnQgdmFsdWUgY2hhbmdlcy4KCglnY2MvdGVzdHN1aXRlLwoJKiBnY2MuZGcvcHI5MzkxNy5jOiBD aGVjayBmb3IgcmFuZ2VzIGluIGZpbmFsIG9wdGltaXplZCBsaXN0aW5nLgoJKiBnY2MuZGcvdHJl ZS1zc2EvdnJwLXVucmVhY2hhYmxlLmM6IERpdHRvLgotLS0KIGdjYy90ZXN0c3VpdGUvZ2NjLmRn L3ByOTM5MTcuYyAgICAgICAgICAgICAgICB8ICA0ICsrLS0KIC4uLi9nY2MuZGcvdHJlZS1zc2Ev dnJwLXVucmVhY2hhYmxlLmMgICAgICAgICB8ICA0ICsrLS0KIGdjYy90cmVlLXNzYW5hbWVzLmNj ICAgICAgICAgICAgICAgICAgICAgICAgICB8IDI0ICsrKysrKysrKy0tLS0tLS0tLS0KIDMgZmls ZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvcHI5MzkxNy5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcv cHI5MzkxNy5jCmluZGV4IGYwOWUxYzQxYWU4Li5mNjM2Yjc3ZjQ1ZCAxMDA2NDQKLS0tIGEvZ2Nj L3Rlc3RzdWl0ZS9nY2MuZGcvcHI5MzkxNy5jCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3By OTM5MTcuYwpAQCAtMSw1ICsxLDUgQEAKIC8qIHsgZGctZG8gY29tcGlsZSB9ICovCi0vKiB7IGRn LW9wdGlvbnMgIi1PMiAtZmR1bXAtdHJlZS12cnAxIC1mZHVtcC10cmVlLXZycDIiIH0gKi8KKy8q IHsgZGctb3B0aW9ucyAiLU8yIC1mZHVtcC10cmVlLXZycDEgLWZkdW1wLXRyZWUtdnJwMiAtZmR1 bXAtdHJlZS1vcHRpbWl6ZWQtYWxpYXMiIH0gKi8KIAogdm9pZCBmMyhpbnQgbik7CiAKQEAgLTE5 LDUgKzE5LDUgQEAgdm9pZCBmMihpbnQqbikKIAogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1k dW1wLXRpbWVzICJHbG9iYWwgRXhwb3J0LiowLCBcXCtJTkYiIDEgInZycDEiIH0gfSAqLwogLyog eyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJfX2J1aWx0aW5fdW5yZWFjaGFibGUi IDEgInZycDEiIH0gfSAqLwotLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJH bG9iYWwgRXhwb3J0LiowLCBcXCtJTkYiIDEgInZycDIiIH0gfSAqLwogLyogeyBkZy1maW5hbCB7 IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJfX2J1aWx0aW5fdW5yZWFjaGFibGUiIDAgInZycDIiIH0g fSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICIwLCBcXCtJTkYiIDIg Im9wdGltaXplZCIgfSB9ICovCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy5kZy90cmVl LXNzYS92cnAtdW5yZWFjaGFibGUuYyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3RyZWUtc3NhL3Zy cC11bnJlYWNoYWJsZS5jCmluZGV4IDU4MzVkZmM4ZGJjLi40YWFkN2YxYmU1ZCAxMDA2NDQKLS0t IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvdnJwLXVucmVhY2hhYmxlLmMKKysrIGIv Z2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvdnJwLXVucmVhY2hhYmxlLmMKQEAgLTEsNSAr MSw1IEBACiAvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLwotLyogeyBkZy1vcHRpb25zICItTzIgLWZk dW1wLXRyZWUtdnJwMS1hbGlhcyAtZmR1bXAtdHJlZS12cnAyLWFsaWFzIiB9ICovCisvKiB7IGRn LW9wdGlvbnMgIi1PMiAtZmR1bXAtdHJlZS12cnAxIC1mZHVtcC10cmVlLXZycDIgLWZkdW1wLXRy ZWUtb3B0aW1pemVkLWFsaWFzIiB9ICovCiAKIHZvaWQgZGVhZCAodW5zaWduZWQgbik7CiB2b2lk IGFsaXZlICh1bnNpZ25lZCBuKTsKQEAgLTM5LDQgKzM5LDQgQEAgdm9pZCBmdW5jICh1bnNpZ25l ZCBuLCB1bnNpZ25lZCBtKQogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiZGVh ZCIgInZycDEiIH0gfSAqLwogLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJi dWlsdGluX3VucmVhY2hhYmxlIiAxICJ2cnAxIiB9IH0gKi8KIC8qIHsgZGctZmluYWwgeyBzY2Fu LXRyZWUtZHVtcC1ub3QgImJ1aWx0aW5fdW5yZWFjaGFibGUiICJ2cnAyIiB9IH0gKi8KLS8qIHsg ZGctZmluYWwgeyBzY2FuLXRyZWUtZHVtcC10aW1lcyAiZmZmOCBWQUxVRSAweDAiIDQgInZycDIi IH0gfSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLXRpbWVzICJmZmY4IFZBTFVF IDB4MCIgMiAib3B0aW1pemVkIiB9IH0gKi8KZGlmZiAtLWdpdCBhL2djYy90cmVlLXNzYW5hbWVz LmNjIGIvZ2NjL3RyZWUtc3NhbmFtZXMuY2MKaW5kZXggMjMzODdiOTBmZTMuLjFlYWU0MTFhYzFj IDEwMDY0NAotLS0gYS9nY2MvdHJlZS1zc2FuYW1lcy5jYworKysgYi9nY2MvdHJlZS1zc2FuYW1l cy5jYwpAQCAtNDE4LDEwICs0MTgsMTcgQEAgc2V0X3JhbmdlX2luZm8gKHRyZWUgbmFtZSwgY29u c3QgdnJhbmdlICZyKQogICBpZiAoci51bmRlZmluZWRfcCAoKSB8fCByLnZhcnlpbmdfcCAoKSkK ICAgICByZXR1cm4gZmFsc2U7CiAKKyAgLy8gUGljayB1cCB0aGUgY3VycmVudCByYW5nZSwgb3Ig VkFSWUlORyBpZiBub25lLgogICB0cmVlIHR5cGUgPSBUUkVFX1RZUEUgKG5hbWUpOworICBWYWx1 ZV9SYW5nZSB0bXAgKHR5cGUpOworICBpZiAocmFuZ2VfaW5mb19wIChuYW1lKSkKKyAgICByYW5n ZV9pbmZvX2dldF9yYW5nZSAobmFtZSwgdG1wKTsKKyAgZWxzZQorICAgIHRtcC5zZXRfdmFyeWlu ZyAodHlwZSk7CisKICAgaWYgKFBPSU5URVJfVFlQRV9QICh0eXBlKSkKICAgICB7Ci0gICAgICBp ZiAoci5ub256ZXJvX3AgKCkpCisgICAgICBpZiAoci5ub256ZXJvX3AgKCkgJiYgIXRtcC5ub256 ZXJvX3AgKCkpCiAJewogCSAgc2V0X3B0cl9ub25udWxsIChuYW1lKTsKIAkgIHJldHVybiB0cnVl OwpAQCAtNDI5LDE4ICs0MzYsMTEgQEAgc2V0X3JhbmdlX2luZm8gKHRyZWUgbmFtZSwgY29uc3Qg dnJhbmdlICZyKQogICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAotICAvKiBJZiBhIGdsb2Jh bCByYW5nZSBhbHJlYWR5IGV4aXN0cywgaW5jb3Jwb3JhdGUgaXQuICAqLwotICBpZiAocmFuZ2Vf aW5mb19wIChuYW1lKSkKLSAgICB7Ci0gICAgICBWYWx1ZV9SYW5nZSB0bXAgKHR5cGUpOwotICAg ICAgcmFuZ2VfaW5mb19nZXRfcmFuZ2UgKG5hbWUsIHRtcCk7Ci0gICAgICB0bXAuaW50ZXJzZWN0 IChyKTsKLSAgICAgIGlmICh0bXAudW5kZWZpbmVkX3AgKCkpCi0JcmV0dXJuIGZhbHNlOworICAv LyBJZiB0aGUgcmVzdWx0IGRvZXNuJ3QgY2hhbmdlLCBvciBpcyB1bmRlZmluZWQsIHJldHVybiBm YWxzZS4KKyAgaWYgKCF0bXAuaW50ZXJzZWN0IChyKSB8fCB0bXAudW5kZWZpbmVkX3AgKCkpCisg ICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICByZXR1cm4gcmFuZ2VfaW5mb19zZXRfcmFuZ2UgKG5h bWUsIHRtcCk7Ci0gICAgfQotICByZXR1cm4gcmFuZ2VfaW5mb19zZXRfcmFuZ2UgKG5hbWUsIHIp OworICByZXR1cm4gcmFuZ2VfaW5mb19zZXRfcmFuZ2UgKG5hbWUsIHRtcCk7CiB9CiAKIC8qIFNl dCBub25udWxsIGF0dHJpYnV0ZSB0byBwb2ludGVyIE5BTUUuICAqLwotLSAKMi40MS4wCgo= --------------5OScnsIkFz6DWjNgHnQ4MTJv--