From: Richard Biener <rguenther@suse.de>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>,
Jeff Law <jeffreyalaw@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] x86: Define LIBGCC2_UNWIND_ATTRIBUTE on ia32 [PR104781]
Date: Wed, 9 Mar 2022 08:18:38 +0100 (CET) [thread overview]
Message-ID: <6ropo03n-18ns-p21-p717-oo9r6nss789p@fhfr.qr> (raw)
In-Reply-To: <CAMe9rOrmJih2TRxd8VkJikRD34TMKGEbd73D+kHQx04ZX5CnbQ@mail.gmail.com>
On Tue, 8 Mar 2022, H.J. Lu wrote:
> On Tue, Mar 8, 2022 at 9:35 AM Jakub Jelinek <jakub@redhat.com> wrote:
> >
> > On Tue, Mar 08, 2022 at 08:09:25AM -0800, H.J. Lu wrote:
> > > > Ok. So, what do you think about replacing the libgcc/ part of your patch
> > > > with that
> > > > /* __builtin_eh_return can't handle stack realignment, so disable SSE in
> > > > 32-bit libgcc functions that call it. */
> > > > #ifndef __x86_64__
> > > > #define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse")))
> > > > #endif
> > > > ?
> > >
> > > Yes, it should work.
> >
> > So, how do we move on with this?
> > I can't self-approve my own patch, so can anyone please ack the following
> > provided it passes bootstraps/regtests ({x86_64,i686}-linux) that are
> > currently pending?
> >
> > That can go in independently from your patch, and if it is committed,
> > your V3 patch with the libgcc/ hunks removed is preapproved for trunk.
> >
> > 2022-03-08 Jakub Jelinek <jakub@redhat.com>
> >
> > PR target/104781
> > * config/i386/i386.h (LIBGCC2_UNWIND_ATTRIBUTE): Define for ia32.
> >
> > --- gcc/config/i386/i386.h.jj 2022-02-25 12:06:45.535493490 +0100
> > +++ gcc/config/i386/i386.h 2022-03-08 11:20:43.207043370 +0100
> > @@ -2848,6 +2848,12 @@ extern enum attr_cpu ix86_schedule;
> > #define NUM_X86_64_MS_CLOBBERED_REGS 12
> > #endif
> >
> > +/* __builtin_eh_return can't handle stack realignment, so disable SSE in
> > + 32-bit libgcc functions that call it. */
> > +#ifndef __x86_64__
> > +#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse")))
> > +#endif
> > +
> > /*
> > Local variables:
> > version-control: t
> >
> >
> > Jakub
> >
>
> LGTM.
I wonder if this is a good case for general-regs-only instead? At
least no-sse cannot be functionally equivalent (since then we would
not have needed general-regs-only ...).
Richard.
next prev parent reply other threads:[~2022-03-09 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 15:06 [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c H.J. Lu
2022-03-08 10:23 ` Jakub Jelinek
2022-03-08 11:15 ` Jakub Jelinek
2022-03-08 12:29 ` Jakub Jelinek
2022-03-08 12:49 ` Eric Botcazou
2022-03-08 15:37 ` H.J. Lu
2022-03-08 15:46 ` Jakub Jelinek
2022-03-08 16:09 ` H.J. Lu
2022-03-08 17:35 ` [PATCH] x86: Define LIBGCC2_UNWIND_ATTRIBUTE on ia32 [PR104781] Jakub Jelinek
2022-03-08 17:49 ` H.J. Lu
2022-03-09 7:18 ` Richard Biener [this message]
2022-03-09 9:59 ` [PATCH] x86, v2: " Jakub Jelinek
2022-03-09 11:30 ` Richard Biener
2022-03-08 17:50 ` [PATCH] x86: " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ropo03n-18ns-p21-p717-oo9r6nss789p@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).