From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15908 invoked by alias); 9 Sep 2011 13:07:59 -0000 Received: (qmail 15897 invoked by uid 22791); 9 Sep 2011 13:07:58 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,MIME_QP_LONG_LINE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Sep 2011 13:07:43 +0000 Received: from geoffrey.Emea.Arm.com (geoffrey.emea.arm.com [10.1.255.46]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id p89D7911015289; Fri, 9 Sep 2011 14:07:09 +0100 (BST) Received: from cam-owa1.Emea.Arm.com ([10.1.255.62]) by geoffrey.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 9 Sep 2011 14:07:41 +0100 Received: from [10.1.18.35] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 9 Sep 2011 14:07:41 +0100 References: <4e69e3f5.0624e70a.66f2.3550SMTPIN_ADDED@mx.google.com> <4E6A0ADD.9030809@arm.com> In-Reply-To: Mime-Version: 1.0 (iPad Mail 8L1) Content-Type: text/plain; charset=us-ascii Message-Id: <702A5D83-A25E-40F9-87E2-F7A1950935A8@arm.com> Content-Transfer-Encoding: quoted-printable Cc: Terry Guo , "gcc-patches@gcc.gnu.org" From: Richard Earnshaw Subject: Re: [Patch, testsuite, arm] Skip the arch conflict to enable case neon-thumb2-move pass on more targets. Date: Fri, 09 Sep 2011 13:59:00 -0000 To: Richard Guenther X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00635.txt.bz2 On 9 Sep 2011, at 14:03, "Richard Guenther" wr= ote: > On Fri, Sep 9, 2011 at 2:47 PM, Richard Earnshaw wrote: >> On 09/09/11 11:07, Richard Guenther wrote: >>> On Fri, Sep 9, 2011 at 12:00 PM, Terry Guo wrote: >>>> Hello, >>>>=20 >>>> This patch enables the case pass on targets other than armv7-a by skip= ping >>>> the architecture conflict message. Is it OK to trunk? >>>=20 >>> I don't like these kind of patches. Why do the testcases have -march= =3Darmv7-a >>> enabled in the first place? If they really need it then they shouldn't= be >>> run with another -march and thus instead there should be a >>> dg-requires-effective-target armv7-a. If they don't really need it >>> they shouldn't >>> add it. >>>=20 >>=20 >> I'm not particularly keen on them either, but with the current structure >> of the testsuite framework the only way to test some unusual option >> combinations is to force them (we can't test every option set, or even >> every CPU supported via multilib testing as it would take ~forever to >> run through all the variants). So the only alternative is to force some >> tests to run with specific options. >>=20 >> It might be easier if there were a specific part of the testsuite which >> was designated to be non-executable, non-multilib. That part would then >> be used without all the multilib paraphernalia that leads to these hacks >> (and would only ever be run once as well, regardless of the number of >> multilibs being tested). But until such time, this patch seems like the >> only way forward. >=20 > I suppose you want a torture that excercises different -march/-mtune > combinations then. >=20 > But can't you do the pruning somewhere in an .exp file then instead > of sprinkling it all over the tests itself? >=20 It seems not. At present the multilib options are all added automatically = by the dejagnu infrastructure. R. > Richard. >=20 >> R. >>=20 >>> Richard. >>>=20 >>>> BR, >>>> Terry >>>>=20 >>>> 2011-09-09 Terry Guo >>>>=20 >>>> * gcc.target/arm/neon-thumb2-move.c: Skip the >>>> architecture conflict to enable the case pass >>>> on targets other than armv7-a. >>>>=20 >>>> diff --git a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c >>>> b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c >>>> index 430a4d5..9cf86dd 100644 >>>> --- a/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c >>>> +++ b/gcc/testsuite/gcc.target/arm/neon-thumb2-move.c >>>> @@ -3,6 +3,7 @@ >>>> /* { dg-require-effective-target arm_thumb2_ok } */ >>>> /* { dg-options "-O2 -mthumb -march=3Darmv7-a" } */ >>>> /* { dg-add-options arm_neon } */ >>>> +/* { dg-prune-output "switch .* conflicts with" } */ >>>>=20 >>>> #include >>>> #include >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>=20 >>=20 >>=20 >=20