From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 2BF053858D37 for ; Sat, 22 Apr 2023 03:18:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BF053858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1a66b9bd893so25557235ad.1 for ; Fri, 21 Apr 2023 20:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682133527; x=1684725527; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0A58UAy+s2rsSkBF9fp9jEyrHzLVNPZQObbzVtrMVwA=; b=ppJ1muMeXZzR6Z4NEWH+8DTAmXUgS5PvRj+IPvF4lCY16mbYTG5EzEyx7QxG7l4u4y QREKUW/B12aRv+ixbt6efJYJ0hUr9/FOg+QoWQLLy6ood5VEN42aj6jE/cUvWqfrRPTg 5gAn7XVW6D2034+7HKdzZaXfpVC+mZSkgDn2wc6zxhxXeUUnjlv0ma5DkaD3tXaBo2Mz rqQEgR+42nrqLjF/BxX1UuH+noLL4SyozqUSAJZLyY1kKV8tmJpZZnUWyt/d25GVmUS9 7i4OgUI4J9rbTsSkhctlM7kpgB1owpZIIdCMKBEFYvIc5JS7/owSzSEcunBNLgldb9Wz Ua0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682133527; x=1684725527; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0A58UAy+s2rsSkBF9fp9jEyrHzLVNPZQObbzVtrMVwA=; b=M6Z6IutyWxIhhKQiExGzI7Q3mapUmPQ0zDxi7eKYJ9HUTY0iuvGSaGNcwxtofvt0jf Z1wEpGmonxcS0mfEXlpJRGnL3OOTJteYIgxv1T4LgDg/ggTi/Ch53RVDhtXoPmw1AI52 R6Oi23GCU6JZ9EluDeT6zcDJXNrNwyjKinCRlUqOlSZZrHV9degFIKpE9qYj6eWp3oPy puDq9pb7wCCgqVIHZ4H2/Cnt9KjwWV2tE/cLB0KoAn2DKVRi/PI5QkK+SUMQkoZVRsiB RAsttq7kWSWfVcjgMAiSeFmU4B6U9FdO1/akwj4wvJ8mC33HfdoWBH2qz1RQJ88dJ7a9 Ta2w== X-Gm-Message-State: AAQBX9d8hsc0tZxzqX74AFYBihVI8HsenGUbQmqGkYpIMLJRDW6EYFNU cmpqug+uOhtavbwa+16c3Tg= X-Google-Smtp-Source: AKy350Yzsha2XZTzhYwtWLcJTTRVV7YOfmbQ3A55/WQg2k/O890irNwwvbalzwglgHW7Uhpj+4/04Q== X-Received: by 2002:a17:903:32c3:b0:19f:3d59:e0ac with SMTP id i3-20020a17090332c300b0019f3d59e0acmr8805289plr.44.1682133526851; Fri, 21 Apr 2023 20:18:46 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::99f? ([2601:681:8600:13d0::99f]) by smtp.gmail.com with ESMTPSA id k17-20020a170902761100b001a9581d60d0sm540505pll.292.2023.04.21.20.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 20:18:46 -0700 (PDT) Message-ID: <704cf9cd-d952-39d8-1d6c-d84fdf8a2a35@gmail.com> Date: Fri, 21 Apr 2023 21:18:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [GCC14 QUEUE PATCH] RISC-V: Optimize fault only first load Content-Language: en-US To: juzhe.zhong@rivai.ai, gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com References: <20230330012804.110539-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20230330012804.110539-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/29/23 19:28, juzhe.zhong@rivai.ai wrote: > From: Juzhe-Zhong > > gcc/ChangeLog: > > * config/riscv/riscv-vsetvl.cc (pass_vsetvl::cleanup_insns): Adapt PASS. This doesn't provide any useful information as far as I can tell. Perhaps something like: Erase AVL from instructions with the fault first load property. OK with a better ChangeLog entry. Related. As a separate patch, can you add a function comment to cleanup_insns? It doesn't have one and it should. Thanks, jeff