From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2f.google.com (mail-oo1-xc2f.google.com [IPv6:2607:f8b0:4864:20::c2f]) by sourceware.org (Postfix) with ESMTPS id 87CB13858282; Mon, 8 Apr 2024 18:21:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87CB13858282 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87CB13858282 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712600493; cv=none; b=t6WUw0EazsRB59elQHyGeoG1SA5FQBp0te9XM4IS8RFHL9LNZ+KMeymx5v/ipadwzknuYI+vu37QOZ0xKxp93f6viSyubTitnYrxZs1X6xgXROpW/VL7tv6Lh9nRozQRWUJ17szaLCt0S4I8F7Zd0NWvforgbG4Wdq++bZn8E5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712600493; c=relaxed/simple; bh=dtiGxBkOlA+QSEJJmYPRgebq247f3Mn3RF6w+I3JlCU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Tk4pzpCvFM1gXeW+J5l9bh+z7fIdOPRPQOqV3uenqF892x4oRAhF42bErPQPamYP96orF8/WSya7NtX9BWVCEQwkiO0ixdyNUqcBcTowcIYkPVv9tMzNJd6+Iz3EVK7MK7WZ93U0wLInEyzRcR3TP/zu9gjmF8VsIBvEHGf4zzo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc2f.google.com with SMTP id 006d021491bc7-5aa17bf8cf0so266558eaf.1; Mon, 08 Apr 2024 11:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712600490; x=1713205290; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=R64J1VdIrnrbCVHuMHKMBvfXvg1fubbTfp/AAVh0CJM=; b=Qxv8EEiyhrAt4EZ/sbZsz4Xq3uR+13k3PcKg0vCz+923JngsbOM4XTWHwcAibuTWR4 Ue2o/TIuL3+xS9HEgnO4TEfeYEPqb/macZJgW8thbKKWNeoCFYoz8OQftCdo078+vtqf vyp+SdSehQyEHOCM/+677U78fT3BFVBUg9aRmBoV04tx4VBSaOhFV9M6rms+WNmn/e0Y Y1ZlRIzltkLw7BjQpkpQBvp7UZBpEsYz5vgdOiCCra0kv1zHg886MrYv/jqBqWUE6kLU AhzcqEJ0wMxm1Zctdk1a1iVjC7Pm+rmN6m7IMOlvr9/oyPpnWY6CHkCpcHDNNUWIIqF5 PuiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712600491; x=1713205291; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R64J1VdIrnrbCVHuMHKMBvfXvg1fubbTfp/AAVh0CJM=; b=EncWbyxo+WzonRnGLxyY0LfViWZXHRAVjlFv8JXbx1WedVFOYeerkgG+zwX7UGVaw/ nCD0tykqzjdAN0yqUOF12piSgtkl0IHGXtOeGFXDUAJhDTtoVZ5frIW+akcf9KGsTbXZ hxEyfozsvbkj+08H7geDMR8oAnaKICuuAeLnpzqMi+QBkVvW8SM+X4RMJ5GwwbBYok/9 SDTKi9h20PbHnzaQWosu6KmYl6qkLFYHz4kYYlSGcMOKqgC0vwFflOgmLBReJWunk+mC H9bTiuOh0yoCuzyXkO4NRUYq3WVF/+kNvodfJyftgWsVLMjJGsu31Dq9sdocLRnES8nG w/AQ== X-Forwarded-Encrypted: i=1; AJvYcCXOTOas1BgGYnGffEYHkDcYEGY36b95jWV+c0VKvNrvHmMXpSOj3GPct+/Srbm2N3JNKwMqlTDOWkVe4L95apLgBuWc X-Gm-Message-State: AOJu0YxIJ1sXM06oj7ORzTrdcWmPIg1w5IyoqiSlkPVS6XRmgBPvE8d5 MwBa5wkZrYubvjKafZ3EdeD8PYnlyQU3GHrouQJGLFHmexxBXkTLvcn/RW1s5KM= X-Google-Smtp-Source: AGHT+IFLQApw/q7diWzUnPslHjICX5eudMMMrdwowlveKgEWXf90/IgKvgSR172q5WaM/TNJ1Lqsfw== X-Received: by 2002:a05:6870:6120:b0:22e:c52e:e7a1 with SMTP id s32-20020a056870612000b0022ec52ee7a1mr10903844oae.1.1712600490673; Mon, 08 Apr 2024 11:21:30 -0700 (PDT) Received: from [192.168.1.24] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id f2-20020a056a000b0200b006e681769ee0sm7162276pfu.145.2024.04.08.11.21.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 11:21:30 -0700 (PDT) Message-ID: <704ed9f8-f7d4-4aaa-8ff6-fd9cc3abab06@gmail.com> Date: Mon, 8 Apr 2024 11:21:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Patch] Fortran: List-directed read - accept again tab as alternative to space as separator [PR114304] To: Tobias Burnus , gfortran Cc: gcc-patches , Jerry D References: <9a848b89-ee95-44f7-8491-cbe22804edf4@gmail.com> <15a39ada-c7fc-433d-ab39-19b897a8a3e8@baylibre.com> <6a742cef-5321-4b34-a2f0-870abd1ba82a@gmail.com> <529f47ca-c398-4e20-a0ef-507842f989d4@baylibre.com> Content-Language: en-US From: Jerry D Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= In-Reply-To: <529f47ca-c398-4e20-a0ef-507842f989d4@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/8/24 2:53 AM, Tobias Burnus wrote: > Jerry D wrote: >> See attached updated patch. > > It turned rather quickly out that this patch – committed as r14-9822-g93adf88cc6744a – caused regressions. > > Namely, real-world code use tab(s) as separator instead of spaces. > > [For instance, PR114304 which contains a named-list input file from SPEC CPU 2017; that example uses tabs before the '=' sign, but the issue is more generic.] > > I think the ISO Fortran standard only permits spaces, but as it feels natural and is widely supported, tabs are used and should remain supported. > > It is not quite clear how '\r' are or should be handled, but as eat_spaces did use it, I thought I would add one testcase using them as well. > > That test is not affected by my change; it did work before with GCC and still does – but it does fail with ifort/ifx/flang. I have not thought deeply whether it should be supported or not – and > looking at the libgfortran source file, it often but (→ testcase) not consistently requires that an \n follows the \r. > > OK for mainline? [And: When the previous patch gets backported, this surely needs to be included as well.] > > Tobias Good catch. I did not even think about tabs. OK to commit and I will take care of it when I do the backport to 13. Thanks! Jerry