From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 83BED3857BBE for ; Fri, 26 Jan 2024 18:25:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 83BED3857BBE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 83BED3857BBE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706293508; cv=none; b=FsTujSHovGg7V0adqv+L6eSs/qnoWPWzKPYcodqP4bACJomm95pXMU9NKWzc/JF40BG/upHSzNML0Qnv+529kfKgw30+z8SmHAnC7u04+s2XgknLN/CBGIy5vpYf8gbpRraC53YcR8QLV7qske69xlQCX6CKNgjYuixSTPBa1jU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706293508; c=relaxed/simple; bh=K6m/AX2J7p7xZJBxDM0wpUKrS1heEuU0rWDy+bE/xL0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nDt/Zd9ZNHi4SKtJHV+mYVKo/0xX3v9ZusdEQv9cnmHq4bFie+2sqsQJv6Eo9TzV3+zlkwNBiY1ETcEjUElobRFNZU6TVggx7RbklxMPnW3G/07bcAIEBIFhFHjBtHbD8OAE0W1wLqy7IzSpvkZjkLbXTQKP4EwKmVP9ZxrsgxM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1d750660a0aso4010995ad.0 for ; Fri, 26 Jan 2024 10:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706293505; x=1706898305; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HXjZb4EPVVx7njAWm7kwAGXSg6Bw1gT7xSyKn3f6hSI=; b=w7h0fBkDDqks28NZCucEBdfE94OvP7XNFqJFBGdJermdoUbr5DCi7HChAr5EcHlrDf 7ivdpW/d1w8+tKYY8jQaeAf9phMHTjvrkvawEarY9sIFB9rBGnTgqGI7PKZXTV6pL4PC 5+JWQyT2FxLHfcYxEerqo63Ykz4EIGdfTYLuzk6HbGxCRt82X3Bf5UtlrAvSy0kCMEHN 2nupeN3twUb2vDln17cg5ECXjGezH/6LbjCXrGZBYmi8EayLH2ooADYZnQ9+SZMaJrQ5 1nUmqOVi665qGPO9O6tUARZQrWqxon3FXGm1Yo6n3GDJqnlr74yN2d3E018lVFqUBW/g M89w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706293505; x=1706898305; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HXjZb4EPVVx7njAWm7kwAGXSg6Bw1gT7xSyKn3f6hSI=; b=VOmBZhZ9/lwCiGfiL5hhcIeukdm0IiJl4WOKmU2yewCL3R4Ic3HjM7gLsgFHue1Gx8 6H85yFqAdcEK8i5ZZN71g/4dMhurQXWIk91EvZFo+jYf1TwETEhNpbFT8WYfI6Fk5VXM s6SDakI9XOLLgBR38Z1zVJe58CpelUbP6GjbBfDHi56CU3TK9EIMCV8RDzD1s3jw06HS lvbkBXRVaAphY6dCbeK+mUJnTtHkbh8XqtHMhohv2MaSEQj+LTqvk90pUPHfU2wKRvZu KMNaMoSg9AlYP2DGPENLUAHwkOGkH6CgpeRbZVzCqc+jQu9MOXf+pY1cMCGVRJ4Yavgi 89tQ== X-Gm-Message-State: AOJu0YzRoRJIulIdFX/FtpFyMPTZ3/6o7kORf5luhkN7vCBqgMUdxaG7 i377DlKVU1Gbna2uSR2Ud5hTwS3Vc3e/3Tk53RVUDz3eigMG0/fJKnQN925kxic= X-Google-Smtp-Source: AGHT+IFc2MzUP96ud8VZE/u2LURZBKULM6zcAbwaWgJFx7sTgcPfSsLbTCi8jimdTlLcGgdOsgPvpg== X-Received: by 2002:a17:903:26d4:b0:1d7:3a3b:c56 with SMTP id jg20-20020a17090326d400b001d73a3b0c56mr230415plb.57.1706293505305; Fri, 26 Jan 2024 10:25:05 -0800 (PST) Received: from [10.0.17.83] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id u17-20020a17090341d100b001d88ba76a8esm1229575ple.59.2024.01.26.10.25.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jan 2024 10:25:04 -0800 (PST) Message-ID: <70506e5e-cd4f-4268-b35c-c6f86ad0020a@rivosinc.com> Date: Fri, 26 Jan 2024 10:25:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 2/4] RISC-V: Add vector related pipelines Content-Language: en-US To: Robin Dapp , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20240112180844.2005246-1-ewlu@rivosinc.com> <20240112180844.2005246-3-ewlu@rivosinc.com> <539cd8a1-a7e2-4592-90a5-35a486c97f43@gmail.com> From: Edwin Lu In-Reply-To: <539cd8a1-a7e2-4592-90a5-35a486c97f43@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/2024 9:06 AM, Robin Dapp wrote: > Thanks, that looks better IMHO. > >> +;; Copyright (C) 2011-2024 Free Software Foundation, Inc. >> +;; Contributed by Andrew Waterman (andrew@sifive.com). >> +;; Based on MIPS target for GNU compiler. > You might want to change that, as well as the date. While at > it you can also fix the broken date in my original file ;) Completely forgot about this. I'll update it :) >> +(define_insn_reservation "vec_load" 6 >> + (and (eq_attr "is_inorder" "no") >> + (eq_attr "type" "vlde,vldm,vlds,vldux,vldox,vldff,vldr")) >> + "vxu_ooo_issue,vxu_ooo_alu") > I would rather ditch the is_inorder attribute for now and define > "low" latencies as well as reservations explicitly once we're > sure rather than falling back to scheduler defaults. I think removing the is_inorder attribute should be ok. I added it because I wanted to avoid having two matching insn reservations defined since matching solely on the type attribute should also match on all subsets as well (i.e. if eventually we add an insn reservation checking for type "vlde" and tune "generic-ooo", any "vlde" insn would map to both reservations) For now I should just remove the is_inorder attribute. We will update the latencies and add new reservations after we know what they should be. Is that correct? > OK with those changes. > > Regards > Robin