From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 55AC33887009 for ; Fri, 23 Jul 2021 06:53:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 55AC33887009 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8AB281FF56; Fri, 23 Jul 2021 06:53:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1627023182; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VrArA5kqQvIeXw8m+lQmR6Ssje/ayEDyq+z9NFtd5JE=; b=Vwh8fyqKxzj5TdZbBsK3PXZwQvKS5+XJw9+LIoloGL/qHpwsxVqOymKjp9rFk0pxMtqdez p9sjdwyF/0EYMyv2VZmXxIT7sVx83s97R01aWW9g/KFZBs5pmC4cadkQ4ueb52L9hU6xVU M/chaZNpMz9A0rFvVdSLHGADMhCbZD8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1627023182; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VrArA5kqQvIeXw8m+lQmR6Ssje/ayEDyq+z9NFtd5JE=; b=afdfGq5yg2GM7ClolTPldPIA+E2kKhjZrZa95wyQjxsgJUQAdCj/doKgWCtwyzgev6nkAP HfXsPLtKl5tWVEAQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 78F86136DD; Fri, 23 Jul 2021 06:53:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id aP1YHE5n+mDcNgAAGKfGzw (envelope-from ); Fri, 23 Jul 2021 06:53:02 +0000 Subject: Re: [PATCH v2] gcov: Add __gcov_info_to_gdca() To: Sebastian Huber , gcc-patches@gcc.gnu.org References: <20210713201553.108947-1-sebastian.huber@embedded-brains.de> <694c7258-5c08-a83d-d6e0-785e71120d68@embedded-brains.de> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <70888d6b-4150-7b37-01ac-7edde6e6be32@suse.cz> Date: Fri, 23 Jul 2021 08:53:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <694c7258-5c08-a83d-d6e0-785e71120d68@embedded-brains.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 06:53:06 -0000 On 7/23/21 8:14 AM, Sebastian Huber wrote: > On 23/07/2021 07:31, Martin Liška wrote: >>>   write_topn_counters (const struct gcov_ctr_info *ci_ptr, >>>                unsigned t_ix, >>> -             gcov_unsigned_t n_counts) >>> +             gcov_unsigned_t n_counts, >>> +             void (*dump) (const void *, unsigned, void *), >>> +             void *(*allocate)(unsigned, void *), >>> +             void *arg) >> >> I would likely prefer dump_fn and allocate_fn argumen t names. > > If I use dump_fn and allocate_fn throughout the code, then several lines would exceed 79 characters.  This needs more vertical space. Should I still add the _fn postfix? > Yes, please do so. Martin