From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 3790A393BA41 for ; Sat, 17 Sep 2022 06:17:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3790A393BA41 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x632.google.com with SMTP id dv25so53703620ejb.12 for ; Fri, 16 Sep 2022 23:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=affjLXAYB3uD9lspmos5EHBsF+ZwNfiwUE+z4lgbZew=; b=FSCFXkopidVvXcSdhnKogCYaAogmMrox/PE1se10/86K/9vqIq9/jExMBThc14NJRl z+YvwFhfrJ/SYSjB6b2XNYmLA5Oc1JFe/rQ2QkEPG/JDl9DeK3cL4q9U+xEtlPilN1Tw caE7Jpg2/+XsUYl+5YU+z5dtRYLvBKAuigraZgsMxjGOqXkV0wFtBsIkxG40BtkVpaHm gpw26OCrfvE4jp9jnXb+lbk2VwkDTg3vF29nVncJ6EgXgbfl081kd/T+5mm9kHJ9TNbz oPllB+vYrPPRWAC+TuFgvGVZp0a8opvHxNkTiZO9YHPZ0hODwBXfTQwnFC0pSLzvhRpi NR5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=affjLXAYB3uD9lspmos5EHBsF+ZwNfiwUE+z4lgbZew=; b=x4lrrsyVzCoag8GZH3ky824o+vZAfqGu5P0NnEC8lKu9GR4tG9gKxX+IaRqnHo4eUO wwU4zp6oXD8Df6XG/S0uojc5A1lEIya+/oUglQqax7MFuVI60Gv5m4hLEbOXd2z9KdBq QfunUyKgfRJC86qV0DpNAWGPG9/z5dYxMdCQGQ5LRbJHwQSLs6sHF1+2uhF6l9dAOKkK 6A6rQDZzBj1rOyuTzMVuMqM98gxE12apxzVL2tF3GePxu3Fw45nVE1eMZMF2Z19xQzTC Ba622/d4690wRd2YeMFeb1Kv1ZvfXXUOPx+e8WRJTu7EWfS4e98+nm3ganpmqGKSvB7A umLQ== X-Gm-Message-State: ACrzQf0IX+h4JIKbfZO2cIJYNsSfrWZ+ph0Fmjyk7zKVPT5ysg4lQLY2 E6mLKEpiBBlED3nj9Qt6c9Y= X-Google-Smtp-Source: AMsMyM7hBCTSdob8vtcsmxYNb5yGEKO6Lu/OiWoBcGzS2xCC5hfYFv+uB1ctRWnxa1pRXN29S8XrrA== X-Received: by 2002:a17:906:a0d3:b0:73d:be5b:2b52 with SMTP id bh19-20020a170906a0d300b0073dbe5b2b52mr5932881ejb.727.1663395447715; Fri, 16 Sep 2022 23:17:27 -0700 (PDT) Received: from [192.168.223.82] (80-188-158-123.rcb.o2.cz. [80.188.158.123]) by smtp.googlemail.com with ESMTPSA id h5-20020a0564020e0500b00450f338b9c8sm14854199edh.69.2022.09.16.23.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Sep 2022 23:17:27 -0700 (PDT) Sender: Nathan Sidwell Message-ID: <7098923e-36f1-7c29-1d3b-941c09a45ab1@acm.org> Date: Sat, 17 Sep 2022 02:17:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] c++: modules ICE with typename friend declaration To: Patrick Palka Cc: GCC Patches , Jason Merrill References: <20220915201627.2942314-1-ppalka@redhat.com> Content-Language: en-US From: Nathan Sidwell In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3033.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/16/22 11:54, Patrick Palka wrote: > On Fri, 16 Sep 2022, Nathan Sidwell wrote: > >> Thanks, this looks right. Sigh templates can mess up ones mental invariants! >> The test case should really be a foo_[ab].C kind, to test both sides of the streaming. Bonus points for using the template after importing.  And you need the dg-module-cmi annotation to check /and then >> delete/ the gcm file produced. > > Aha, thanks very much for the pointers, I redid the testcase using > lang-3_[abc].C as an example. How does the following look? > yes, that's right, thanks! nathan -- Nathan Sidwell