From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A7D8A385841A for ; Wed, 7 Sep 2022 15:33:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7D8A385841A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 287FOPhr025075 for ; Wed, 7 Sep 2022 15:33:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=G9Rt9ST+cmY9/7b+kkigOsYUVZ3jAcG4J2cL3c27u/c=; b=mhHhv96F60icmpxVNPIGyt7EuZcgLmHWw/aE2GDcW+LXc0z2ACyq2WoK7UyTxDtjt5lT zBpuI7HZ95A36+EpGkXdgdVc9K0hf2gyR45+KaUdl7s4a/+CBPQfVl4MYSQha+hGh+h6 /FI0O9EdesT5HrVjACM5iYocrI7Qh2uYsavXoUtxa4i8sNY8q14iCk6WR+Un4tuHdGng kvKM2Cvv74AZyVTLTU3Vpxhd3l3vhhSqqghUftMHrYGvtZRwejBfuOiyHBFOP+D0L6sA 0xRiOfpZ0SMh+4+LcPgoaG7agBwwweW7r3Jywvn0ecGeoqoHT59ERWEQPUL/mOzwYfjs eA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jewws08tq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 07 Sep 2022 15:33:49 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 287FPKTT027867 for ; Wed, 7 Sep 2022 15:33:48 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3jewws08sr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Sep 2022 15:33:48 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 287FKRf4025149; Wed, 7 Sep 2022 15:33:46 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma03ams.nl.ibm.com with ESMTP id 3jbxj8wcqk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Sep 2022 15:33:46 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 287FY7oH43188624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Sep 2022 15:34:07 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 12A10A405B; Wed, 7 Sep 2022 15:33:44 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB536A4059; Wed, 7 Sep 2022 15:33:43 +0000 (GMT) Received: from [9.171.19.250] (unknown [9.171.19.250]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 7 Sep 2022 15:33:43 +0000 (GMT) Message-ID: <70a54b9a-30ea-5673-3a41-9585b3abf627@linux.ibm.com> Date: Wed, 7 Sep 2022 17:33:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [RFC] postreload cse'ing vector constants Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org References: <3b0984ef-c532-c29c-732a-1c9b569e134c@linux.ibm.com> <7ecca009-32ac-3b2f-e552-55414300113e@gmail.com> From: Robin Dapp In-Reply-To: <7ecca009-32ac-3b2f-e552-55414300113e@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: NlX8nvU005OhnNN1L8eL8VM--7epkzSe X-Proofpoint-GUID: 24uZrNycsNwYzwIEAJdP_2HyhFIR01gB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-07_08,2022-09-07_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 suspectscore=0 phishscore=0 mlxlogscore=975 impostorscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2209070060 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Did you did any archeology into this code to see if there was any > history that might shed light on why it doesn't just using the costing > models? This one was buried under some dust :) commit 0254c56158b0533600ba9036258c11d377d46adf Author: John Carr Date: Wed Jun 10 06:00:50 1998 +0000 reload1.c (reload_cse_simplify_operands): Do not call gen_rtx_REG for each alternative. Wed Jun 10 08:56:27 1998 John Carr * reload1.c (reload_cse_simplify_operands): Do not call gen_rtx_REG for each alternative. Do not replace a CONST_INT with a REG unless the reg is cheaper. From-SVN: r20402 Back then we didn't have vectors I suppose but apart from that I don't see a compelling reason not to unconditionally check costs from this. It seems like we did even more unconditional replacing before it, including CONST_INTs. Regards Robin