From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id E0F84385E440 for ; Fri, 27 Oct 2023 13:44:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0F84385E440 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0F84385E440 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698414253; cv=none; b=g4qnfKWuNsd9XaznqV+gQjJEK6cc6B/nViujyJ1rw0PPl179wJuCoMetqwbdrq5OwOcsEViA4aPpsIC/EmHji1+axTPeJjjx7TaJAvHK6AO3TYuDRYzf4KWNom+yJAJ3h9NzPPborZXXyNCr63gRzEvyj41QJrkTuEBtfIjNPPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698414253; c=relaxed/simple; bh=uLnq5xM4Ux6yjdob08RRF3My11lGiTpNUxooR0GISns=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=g4cuvJqYn3Sfbc7OcLuro26pK9ZMLm+wc2DxLaEx+oeMX2pj2Km8q5OH/qyn0Ui0lY4dIRh5AStTpFMb/ot/0jq/c6i5AkheJwiWUp+eswcFICL6hB/XuQQG3GCgJyAn6zB1F2tm0sa6ajstILsEfoIrk1L24KVeleHQux8s2cM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-280137f1a1bso370166a91.1 for ; Fri, 27 Oct 2023 06:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698414251; x=1699019051; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P3pHCxLv2tMvaj1T4KkKnPCp3qhsk4T11uoLTUZVy3U=; b=WnmMIF9rKhl5PBtja5TsgndDy6tndYkTvkv9WwX797eUChMpfMgSX9Ubv+H1bhIBDr VvslNkclqinJ4ooX/4moiruKFdhHNEIMXWLBikPrxi+aofr0986e4GVr4uKu+xspBNhp wKHYiLRldu/v4vzL0C9971x1HonKePzTTweOvmIXIw3k3EfkA76NkbjjEskrZ+qQZqdY s4E3AVvEm95hLx5os12iK03BgKQ8Gy6V6e4F8zhsQl9Glqvh2XqVFZ2JVhmKYBanoMFW KUSPzmUa+Xj3ZWsFoG4T8eiwtkQ95la7Q7e9BTugq22/sk/obqfEliJFjYVrjNvFttdv CFTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698414251; x=1699019051; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P3pHCxLv2tMvaj1T4KkKnPCp3qhsk4T11uoLTUZVy3U=; b=vuEarBY0nS0C5MxzMblAO8PwDx40Q5i2RHwmftCijkwnmBIbEiiO+Uy5dJE9aPXI2s cwlEEk3Ps6iPWm6WU7tnxdjP0OixSS8DnU4HkOwT58mAsWvLhf+LBm1/r/gzdsbj76Yc zmacwDmMKgAhNFvo7nGFjvYgUYcQOvnt3XQcLGHKzLb+LoIY8qIePLChVXABNYeS7JLq 8L441YfUjO1NfEBCWKjsoflq3U8GrQ3W0Ag3riCB9J+zd/3/Zuad5Cty93R7Z0sC2jP9 SFkgHziiDG3bWCdOsls4pr5iQIKsQ4nXr7O7ATo+D1W1kQjCrtoKSZeJWZyHxZKHVMEv MDGQ== X-Gm-Message-State: AOJu0YzHFKclGAITdkeKW7sTaclM2t1vMvh51DXWPfAI96+VwECIdZQm r7uGLYQGiAKlQU04gF+uFrKiSma/MBM= X-Google-Smtp-Source: AGHT+IHLpEiJMbnciVjyEtlFjKQmvb3o10FjnHCJ0AmV8quhAHYbrVWwSE7Hi2NCu7xNC4Cx1o1MvA== X-Received: by 2002:a17:90b:17ca:b0:27f:fe7e:92fe with SMTP id me10-20020a17090b17ca00b0027ffe7e92femr2463121pjb.43.1698414250740; Fri, 27 Oct 2023 06:44:10 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id gt1-20020a17090af2c100b0026b3f76a063sm1232651pjb.44.2023.10.27.06.44.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Oct 2023 06:44:10 -0700 (PDT) Message-ID: <70dd6cd2-33be-44f5-a4cb-0300f5756b39@gmail.com> Date: Fri, 27 Oct 2023 07:44:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Fix wrong tune parameters on int_div Content-Language: en-US To: "juzhe.zhong@rivai.ai" , gcc-patches Cc: "kito.cheng" , "Kito.cheng" , chenyangyu References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/27/23 01:37, juzhe.zhong@rivai.ai wrote: > LGTM from my side. > > The original integer division COST seems too low. Almost certainly, though there may be good reasons why it was initially set so low. I'm generally hesitant to change things like that without either someone with knowledge of the code/uarch stepping in with a recommendation or some kind of analysis showing their wrong. > > Hi, Jeff and Kito. Could take a look at this patch ? It's on the list. jeff