From: FX <fxcoudert@gmail.com>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Fortran List <fortran@gcc.gnu.org>
Subject: Re: [patch,libgfortran,toplevel] Use libbacktrace in libgfortran
Date: Mon, 24 Aug 2015 07:15:00 -0000 [thread overview]
Message-ID: <7104784A-85EA-4334-8603-604BFA5CEDE2@gmail.com> (raw)
In-Reply-To: <CAO9iq9HELEH_j_yqXoXB0+Ha2r833Bn69X5M__D5Xx51ukC8ig@mail.gmail.com>
> Ah, I didn't realize that. I guess you're right, it's better to split
> the filename:linenumber to a separate line. But still, I think it's
> clearer if you keep the "in" and "at" like the current code & gdb
> does. Thus, something like
>
> #framenumber 0xADDRESS in funcname
> at filename:linenumber
Done.
> And another thing which I previously missed: You have removed the
> store_exe_path function as it's no longer used for anything. However,
> that function is part of the libgfortran ABI and is found in
> gfortran.map, so we have to keep it until we bump the so version. :(
Which is what I did, though it’s not very clear from the .diff itself. The function is emptied but remains in libgfortran/runtime/main.c:
void
store_exe_path (const char * argv0 __attribute__ ((unused)))
{
/* This function is now useless, but is retained due to ABI compatibility.
Remove when bumping the library ABI. */
;
}
> Please also add a note to the libgfortran ABI cleanup wiki page so we
> don't forget about it.
Done.
> With these changes, Ok for trunk. Thanks a lot for working on this!
Committed as revision 227106 with the changes above.
Thanks for reviewing the patch.
FX
next prev parent reply other threads:[~2015-08-23 21:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 13:19 Uros Bizjak
2015-08-14 14:31 ` FX
2015-08-23 20:14 ` Janne Blomqvist
2015-08-23 20:59 ` FX
2015-08-23 21:27 ` Janne Blomqvist
2015-08-24 7:15 ` FX [this message]
2015-08-24 16:00 ` Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran" Hans-Peter Nilsson
2015-08-24 16:08 ` FX
2015-08-24 16:44 ` Hans-Peter Nilsson
2015-08-24 18:42 ` FX
2015-08-25 3:29 ` Ian Lance Taylor
2015-08-25 13:25 ` Ulrich Weigand
2015-08-25 17:09 ` Hans-Peter Nilsson
2015-08-25 17:57 ` Ulrich Weigand
2015-08-26 0:09 ` Hans-Peter Nilsson
2015-08-26 12:17 ` Ulrich Weigand
2015-08-26 12:34 ` Hans-Peter Nilsson
2015-08-26 15:37 ` [PATCH] Fix and simplify (Re: Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran") Ulrich Weigand
2015-08-27 4:02 ` Ian Lance Taylor
2015-08-27 13:38 ` Ulrich Weigand
2015-08-27 14:02 ` Ian Lance Taylor
2015-08-24 16:04 ` Fix libbacktrace -fPIC breakage from "Use libbacktrace in libgfortran" Hans-Peter Nilsson
-- strict thread matches above, loose matches on Subject: below --
2015-08-14 9:23 [patch,libgfortran,toplevel] Use libbacktrace in libgfortran FX
2015-08-14 14:19 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7104784A-85EA-4334-8603-604BFA5CEDE2@gmail.com \
--to=fxcoudert@gmail.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).