From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by sourceware.org (Postfix) with ESMTPS id BDF2F385C017 for ; Tue, 31 Mar 2020 17:15:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BDF2F385C017 Received: by mail-pl1-x643.google.com with SMTP id t4so2395727plq.12 for ; Tue, 31 Mar 2020 10:15:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0EbK1tOfUN2K/XSGbgIxs5/Q5yOe73QuPqdzwws2X5g=; b=YaiOST0j4ZrcVZCmeK6rTVscsPF9WVpldptNarLoG2/UXWCLpKIyWN/ckh3YqaeJF+ Qv7OTzRoRm79dq6VN9EEPn+zoX7GefHGKttGSVE197XX35IeEsM/pcJU+zWb7u8oVxFn Cs0FAFiybq2kLNuMFkpzdezrfbJsozvoeeUKJBTUTkW3xdAULF7gjBg1AXMo5GN4IJjx AGrUix8GXgOAD5tsknPlSts81GamKTXRsrTIe5FHihi/Ih+sfOovGZOER2sywdBGHvcF ZXESCRPzhCK6RtD/jlAfIeWcsTEaFdukXFin1Y9s08oF4gT6Vu5iDZwzyHkBPGiW4kFl /i4w== X-Gm-Message-State: ANhLgQ2+zHMzi/6ajty5KkoRKAktux9R2qx7nAW1LzFnv0TCtzoRwzIf wGiOtWNxlGmb5UDxkfQ/A3sNJZkp/QA= X-Google-Smtp-Source: ADFU+vvF/sjmWt865xRjNC44PwUhCHgqG6Hs3d/QMk0PdquGtr/8MCaEdk/EyQZDn7pWKXdpvP1xgw== X-Received: by 2002:a17:902:7283:: with SMTP id d3mr17925510pll.65.1585674912641; Tue, 31 Mar 2020 10:15:12 -0700 (PDT) Received: from [192.168.1.11] (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id d3sm2370164pjc.42.2020.03.31.10.15.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2020 10:15:11 -0700 (PDT) Subject: Re: [PATCH v2 1/9] aarch64: Accept 0 as first argument to compares To: gcc-patches@gcc.gnu.org, richard.earnshaw@arm.com, marcus.shawcroft@arm.com, kyrylo.tkachov@arm.com, Wilco.Dijkstra@arm.com, richard.sandiford@arm.com References: <20200321024231.13778-1-richard.henderson@linaro.org> <20200321024231.13778-2-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <713211ca-634e-770e-a191-32702b5c1f04@linaro.org> Date: Tue, 31 Mar 2020 10:15:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 17:15:15 -0000 On 3/31/20 9:55 AM, Richard Sandiford wrote: >> (define_insn "cmp" >> [(set (reg:CC CC_REGNUM) >> - (compare:CC (match_operand:GPI 0 "register_operand" "rk,rk,rk") >> - (match_operand:GPI 1 "aarch64_plus_operand" "r,I,J")))] >> + (compare:CC (match_operand:GPI 0 "aarch64_reg_or_zero" "rk,rk,rkZ") >> + (match_operand:GPI 1 "aarch64_plus_operand" "I,J,rZ")))] >> "" >> "@ >> - cmp\\t%0, %1 >> cmp\\t%0, %1 >> - cmn\\t%0, #%n1" >> - [(set_attr "type" "alus_sreg,alus_imm,alus_imm")] >> + cmn\\t%0, #%n1 >> + cmp\\t%0, %1" >> + [(set_attr "type" "alus_imm,alus_imm,alus_sreg")] >> ) >> >> (define_insn "fcmp" > > ...does adding 'Z' to operand 1 enable any new combinations? Not useful ones, on reflection, but given it's a valid combination, it's easier to include it than not. I can certainly remove that. r~