From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107714 invoked by alias); 1 Aug 2018 11:01:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107613 invoked by uid 89); 1 Aug 2018 11:01:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Aug 2018 11:01:21 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 45A97AF54; Wed, 1 Aug 2018 11:01:19 +0000 (UTC) Subject: Re: [PATCH,nvptx] Remove use of 'struct map' from plugin (nvptx) To: Cesar Philippidis References: <1f1721dd-e1e6-b169-e5e6-d62e5eada1cd@mentor.com> Cc: "gcc-patches@gcc.gnu.org" From: Tom de Vries Message-ID: <713db0db-ac26-edde-b185-962830503493@suse.de> Date: Wed, 01 Aug 2018 11:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1f1721dd-e1e6-b169-e5e6-d62e5eada1cd@mentor.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00039.txt.bz2 On 07/31/2018 05:12 PM, Cesar Philippidis wrote: > This is an old patch which removes the struct map from the nvptx plugin. > I believe at one point this was supposed to be used to manage async data > mappings, but in practice that never worked out. I don't quite understand what rationale you're trying to present here. Is this dead code? If not, what kind of test-case exercises this? What is the difference in behaviour for such a test-case with and without the patch? Thanks, - Tom