From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 376 invoked by alias); 6 Jun 2002 06:19:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 310 invoked from network); 6 Jun 2002 06:19:49 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 6 Jun 2002 06:19:49 -0000 Received: from porcupine.cygnus.com (romulus.sfbay.redhat.com [172.16.27.251]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id XAA17346 for ; Wed, 5 Jun 2002 23:19:48 -0700 (PDT) Received: from porcupine.cygnus.com (IDENT:XgoNTVsjkWyEhNumRnEHE6pIwp1i8rRY@localhost.localdomain [127.0.0.1]) by porcupine.cygnus.com (8.12.2/8.12.2) with ESMTP id g566NCI7007144; Thu, 6 Jun 2002 00:23:12 -0600 Received: from porcupine.cygnus.com (law@localhost) by porcupine.cygnus.com (8.12.2/8.12.2/Submit) with ESMTP id g566NAYn007141; Thu, 6 Jun 2002 00:23:10 -0600 To: "John David Anglin" cc: jh@suse.cz (Jan Hubicka), gcc-patches@gcc.gnu.org, rth@redhat.com Subject: Re: [PATCH] Jump bypassing and improved cprop (take 2) Reply-To: law@redhat.com From: law@redhat.com In-reply-to: Your message of Thu, 06 Jun 2002 00:30:17 EDT. <200206060430.g564UHjX021278@hiauly1.hia.nrc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 05 Jun 2002 23:19:00 -0000 Message-ID: <7140.1023344590@porcupine.cygnus.com> X-SW-Source: 2002-06/txt/msg00525.txt.bz2 In message <200206060430.g564UHjX021278@hiauly1.hia.nrc.ca>, "John David Anglin " writes: > > > There only appears to be a couple of other ports with similar code to > > > determine the size of a function. Most other uses of INSN_ADDRESSES > > > are probably ok. Possibly, the function "get_last_nonnote_insn" could > > > be put in emit-rtl.c. Then, it wouldn't be too onerous to change all > > > the ports. > > > > Yes, this looks like sensible approach to me. Thanks for fixing it! > > This is the fix that I would like to apply to fix the problem of determining > the size of a function under hppa-linux and hppa64-hp-hpux11. I believe > that the patch is functionally equivalent to what I proposed before for > just the PA port. I have moved get_last_nonnote_insn to emit-rtl.c > and created a corresponding get_first_nonnote_insn for the avr port. > There is some question in my mind whether the latter question is actually > necessary but I don't want to second guess the code in avr.c. > > Bootstrapped and regression tested under hppa-linux. > > OK for mainline? > > Dave > -- > J. David Anglin dave.anglin@nrc.ca > National Research Council of Canada (613) 990-0752 (FAX: 952-66 > 05) > > 2002-06-04 John David Anglin > > * emit-rtl.c (get_first_nonnote_insn, get_last_nonnote_insn): New > functions. > * rtl.h (get_first_nonnote_insn, get_last_nonnote_insn): Declare. > * avr/avr.c (avr_output_function_epilogue): Use above to determine > function size. > * pa/pa.c (pa_output_function_prologue): Likewise. This is fine. Thanks, jeff