From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 3AB043858D28 for ; Thu, 25 Jan 2024 06:12:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AB043858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3AB043858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706163178; cv=none; b=qLigeW7e0VbU1ZSGHMdZCOeRwWqyHXvNuLKnFJExcstSDmrsd9lTIu+Is+YSysJFLbNwh13izF3XVN2wfy7uhR1pWVHM9CCXHpO1utzmu48X2KURZVrjFJnxRMu231CMgf1hI3XtjceWnY950wAaYa8we/M2yRWGPpfxlFX5R7Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706163178; c=relaxed/simple; bh=3MPsBnQqEdHjyf7d08F8ZR4rvt5yP7qe/zrqhStVaeo=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=po/i+yZkH1KDyd83jcRY/Gsa+1Nef+xeljpY1/dy0Ji8NUAR5IlyI+4TNd2Ryuaq+HGkaF9WAJBTRcvvG9qQClcohcWcCbsnRgRk4zFsXjPba52PWFuhgIRVzEDWli8SxcUnFpS6QMDN3VeAhUACrWeIOdcS78JvuQBYGq5N3u0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8CxifDk+7FljmIFAA--.20617S3; Thu, 25 Jan 2024 14:12:53 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3c7j+7Flwq8YAA--.42317S3; Thu, 25 Jan 2024 14:12:52 +0800 (CST) Subject: Re: [PATCH] LoongArch: Fix incorrect return type for frecipe/frsqrte intrinsic functions To: Jiahao Xu , Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20240124091932.38877-1-xujiahao@loongson.cn> <291eac07320a425b5e6ce26d801bde2c2d5f4cdd.camel@xry111.site> <6574fefa-1c6f-a6d2-d332-74808fe22dee@loongson.cn> From: chenglulu Message-ID: <71559384-ce98-71de-76e6-49a954e7ca79@loongson.cn> Date: Thu, 25 Jan 2024 14:12:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <6574fefa-1c6f-a6d2-d332-74808fe22dee@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Ax3c7j+7Flwq8YAA--.42317S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7CF4UJryfur1DArWDAw1UArc_yoW8WFWkpF 1kA3ZIyr48CFZ7Gryqv343Xw1YvrZrKwnruFy3Ka48GrsrtryIgF4agrZI9Fn8Gw48JF4S vFWftF9Iva13A3gCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv2b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1QV y3UUUUU== X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,BODY_8BITS,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2024/1/24 下午5:58, Jiahao Xu 写道: > > 在 2024/1/24 下午5:48, Xi Ruoyao 写道: >> On Wed, 2024-01-24 at 17:19 +0800, Jiahao Xu wrote: >>> gcc/ChangeLog: >>> >>>     * config/loongarch/larchintrin.h >>>     (__frecipe_s): Update function return type. >>>     (__frecipe_d): Ditto. >>>     (__frsqrte_s): Ditto. >>>     (__frsqrte_d): Ditto. >>> >>> gcc/testsuite/ChangeLog: >>> >>>     * gcc.target/loongarch/larch-frecipe-intrinsic.c: New test. >>> >>> diff --git a/gcc/config/loongarch/larchintrin.h >>> b/gcc/config/loongarch/larchintrin.h >>> index 7692415e04d..ff2c9f460ac 100644 >>> --- a/gcc/config/loongarch/larchintrin.h >>> +++ b/gcc/config/loongarch/larchintrin.h >>> @@ -336,38 +336,38 @@ __iocsrwr_d (unsigned long int _1, unsigned >>> int _2) >>>   #ifdef __loongarch_frecipe >>>   /* Assembly instruction format: fd, fj.  */ >>>   /* Data types in instruction templates:  SF, SF.  */ >>> -extern __inline void >>> +extern __inline float >>>   __attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) >>>   __frecipe_s (float _1) >>>   { >>> -  __builtin_loongarch_frecipe_s ((float) _1); >>> +  return (float) __builtin_loongarch_frecipe_s ((float) _1); >> I don't think the (float) conversion is needed. >> >> > Indeed, this float conversion is unnecessary; I simply included it to > align with the definitions of other intrinsic functions. This is generated in batches like vectors, so there will be such redundant symbol type conversion. We will remove the redundant types later.