From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id CA2063858D35 for ; Thu, 7 Sep 2023 17:31:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA2063858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1bdf4752c3cso9635035ad.2 for ; Thu, 07 Sep 2023 10:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1694107887; x=1694712687; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DTbwyrAO9pDrNJYRxq0mmEVWW7DdQmfnUyXsMylmLh4=; b=wdOFgzF0o1KxftrxIihwuhLZCxCTxsRbjNAWGg8dmN1Gj4/WqTuTqvqyARt1FtUVbh FsmeU/i4wlF2zB1BDOdXwuXi9sXbTabLcl7QCeXUp26RLznjrMka73E7JVN+pYBYx2Qv KQWI86MevKnaXq68GuvzdZ/J4HUkzyjAprOlfjtOCw1x8ddy0AAULisngKYVPcMEvP9e dE0JVPRTVzNsg3AZKw2S9LzCvTPz+F6NFhZvKHKe844UMMX/mvx3zRgrc9gAdJNi26xO 7a06lpzfjVICu5jpdEMj2k2GTW0heP4WwFCEDL5gTDXe0BcT9VHoXnUE/ancVUTEo3If 0f6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694107887; x=1694712687; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DTbwyrAO9pDrNJYRxq0mmEVWW7DdQmfnUyXsMylmLh4=; b=Of2OW6/q2Xeg/5QUt6yt0Ww4zu04U7A8WBlmfCmLf93ilNSSeiZnpdgH4htcUBID21 w9ZYPLYjp5ItS09ADVTTNKdJK1JhrHbU/X+Lw8Lpr0GSD/n6GaJWqujOn9VpsYCZoSKK +bzKKXtbWiti7HX8AKFzBABDkfeGEuQlAa81JIsQKU4XTn+jP3ytuetmXe65eDto5sOm FsIlATJwTuhLHgDDqCE6t6x1+IsllUTQ6sP2eiaM0vxGC+/2XdWz+QBggNfH4NJzyT4Z yHnZLnc8QHee2raeimmGGdeQ7962Jiyb8dKbai+F84UniYLS1uYgt7/MZvFdCeEijkvg uXOA== X-Gm-Message-State: AOJu0YxLWqLzyql6bOXCxporzqbEunh5DQVVgrWrZ71mpu1ztRuBMznK P3VAlZMpEYamVDIp0d6aYYt09g== X-Google-Smtp-Source: AGHT+IGHIIjN/+gXrqwhrcHwoeWQX6FZXS1rKIQ7rqddiDcxbpGqHLXigB8XERzsR47p1Fmo6xDUyg== X-Received: by 2002:a17:902:ce8d:b0:1b8:a389:4410 with SMTP id f13-20020a170902ce8d00b001b8a3894410mr361152plg.0.1694107886863; Thu, 07 Sep 2023 10:31:26 -0700 (PDT) Received: from [10.0.16.63] ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id bu3-20020a632943000000b00563ff7d9c4bsm12942807pgb.73.2023.09.07.10.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 10:31:26 -0700 (PDT) Message-ID: <716e2796-c281-42ab-8916-4ce9206abd07@rivosinc.com> Date: Thu, 7 Sep 2023 10:31:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] RISC-V: Remove Assert Protecting Types Content-Language: en-US To: Jeff Law , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20230906175025.935887-1-ewlu@rivosinc.com> <20230906175025.935887-6-ewlu@rivosinc.com> From: Edwin Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/7/2023 6:19 AM, Jeff Law wrote: > > > On 9/6/23 11:50, Edwin Lu wrote: >> This patch turns on the assert which ensures every instruction has type >> that is not TYPE_UNKNOWN. >> >> gcc/ChangeLog: >> >>     * config/riscv/riscv.cc (riscv_sched_variable_issue): Remove assert > And this is fine.  But hold off committing until all the dependencies > are also committed.  I think there's still one earlier patch that I > wanted to look at again. > > jeff Sounds good to me. The thead instructions were the ones that haven't been checked in yet. Edwin