From: Thomas Koenig <tkoenig@netcologne.de>
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Implement maxloc and minloc for character
Date: Thu, 23 Nov 2017 18:40:00 -0000 [thread overview]
Message-ID: <717c0598-cc09-390a-72fa-906b2a4d106e@netcologne.de> (raw)
In-Reply-To: <CAO9iq9FSybi=rK04ah07MiS9K1v4KKhP=d3X7+20BQKzA8H4PA@mail.gmail.com>
Hi Janne,
> However, to continue my nitpicking (sorry!), it seems that in many
> cases compare_fcn still takes an integer length argument. Could you
> make that gfc_charlen_type as well? Or maybe size_t, since the
> argument is passed straight to memcmp{_char4} anyway? Please consider
> such a patch pre-approved. Thanks!
Committed as r255109.
I had missed out on the non-inlined maxval and maxloc versions...
The fun with max* and min* intrinsics is not yet over. Maxval and
Minval have yet to be implemented for character arguments, and then
there is the BACK argument to MAXLOC.
Maybe (while we are breaking compatibility) we should just add BACK
to the front end, reject it whith a "not yet implemented" message,
add the argument to the library and worry about implementation
later.
What do you think?
Regards
Thomas
next prev parent reply other threads:[~2017-11-23 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 22:04 Thomas Koenig
2017-11-20 8:41 ` Janne Blomqvist
2017-11-20 18:33 ` Thomas Koenig
2017-11-21 16:25 ` Janne Blomqvist
2017-11-21 19:53 ` Thomas Koenig
2017-11-21 20:47 ` Janne Blomqvist
2017-11-22 18:16 ` Thomas Koenig
2017-11-23 13:25 ` Janne Blomqvist
2017-11-23 14:03 ` Janne Blomqvist
2017-11-23 14:06 ` Ramana Radhakrishnan
2017-11-23 14:10 ` Janne Blomqvist
2017-11-23 18:40 ` Thomas Koenig [this message]
2017-11-24 9:33 ` Janne Blomqvist
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=717c0598-cc09-390a-72fa-906b2a4d106e@netcologne.de \
--to=tkoenig@netcologne.de \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).