From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18635 invoked by alias); 23 Nov 2017 17:58:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18617 invoked by uid 89); 23 Nov 2017 17:58:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=BACK X-Spam-User: qpsmtpd, 2 recipients X-HELO: cc-smtpout1.netcologne.de Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 17:58:42 +0000 Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203]) by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 26E0913461; Thu, 23 Nov 2017 18:58:40 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 231B111D8D; Thu, 23 Nov 2017 18:58:40 +0100 (CET) Received: from [78.35.131.92] (helo=cc-smtpin3.netcologne.de) by localhost with ESMTP (eXpurgate 4.1.9) (envelope-from ) id 5a170c50-02b7-7f0000012729-7f000001e475-1 for ; Thu, 23 Nov 2017 18:58:40 +0100 Received: from [192.168.178.20] (xdsl-78-35-131-92.netcologne.de [78.35.131.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA; Thu, 23 Nov 2017 18:58:37 +0100 (CET) Subject: Re: [patch, fortran] Implement maxloc and minloc for character To: Janne Blomqvist Cc: "fortran@gcc.gnu.org" , gcc-patches References: <44c7b39b-d849-e31a-7175-80bf1a348908@netcologne.de> <03e85917-b506-0d8b-78b0-263c371cba6a@netcologne.de> <09d35ad1-6883-0372-7a1a-840c8c4b07f9@netcologne.de> <781c7918-5600-c488-0528-0c351ea04442@netcologne.de> From: Thomas Koenig Message-ID: <717c0598-cc09-390a-72fa-906b2a4d106e@netcologne.de> Date: Thu, 23 Nov 2017 18:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg02148.txt.bz2 Hi Janne, > However, to continue my nitpicking (sorry!), it seems that in many > cases compare_fcn still takes an integer length argument. Could you > make that gfc_charlen_type as well? Or maybe size_t, since the > argument is passed straight to memcmp{_char4} anyway? Please consider > such a patch pre-approved. Thanks! Committed as r255109. I had missed out on the non-inlined maxval and maxloc versions... The fun with max* and min* intrinsics is not yet over. Maxval and Minval have yet to be implemented for character arguments, and then there is the BACK argument to MAXLOC. Maybe (while we are breaking compatibility) we should just add BACK to the front end, reject it whith a "not yet implemented" message, add the argument to the library and worry about implementation later. What do you think? Regards Thomas