Re: [PATCH] jit: Ensure ssize_t is defined.

[FX Coudert <fxcoudert@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 612 bytes --]

Hi

I can’t seem to get a review of this one-line patch. Could a global reviewer help?
Thanks,

FX



ping**3


> Le 11 mai 2024 à 17:16, FX Coudert <fxcoudert@gmail.com> a écrit :
> 
> Hi,
> 
> On some targets it seems that ssize_t is not defined by any of the headers transitively included by <stdio.h>. This leads to a bootstrap fail when jit is enabled. The attached patch fixes it by include <sys/types.h>. Other headers in GCC treat <sys/types.h> as available on all targets, so we include it unconditionally.
> 
> Tested on x86_64-darwin and x86_64-linux. OK to push?
> 
> FX
> 

[-- Attachment #2: 0001-jit-Ensure-ssize_t-is-defined.patch --]
[-- Type: application/octet-stream, Size: 983 bytes --]

From 18b6a76a4299e1bb946efc2ce401fc09827e1271 Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Sat, 11 May 2024 17:08:05 +0200
Subject: [PATCH] jit: Ensure ssize_t is defined

On some targets it seems that ssize_t is not defined by any of the
headers transitively included by <stdio.h>.  This leads to a bootstrap
fail when jit is enabled.

Other code in GCC treats <sys/types.h> as available on all targets,
so let's include it unconditionaly.

gcc/jit/ChangeLog:

	* libgccjit.h: Include <sys/types.h>
---
 gcc/jit/libgccjit.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/jit/libgccjit.h b/gcc/jit/libgccjit.h
index 74e847b2dec..cbe0f70abee 100644
--- a/gcc/jit/libgccjit.h
+++ b/gcc/jit/libgccjit.h
@@ -21,6 +21,7 @@ along with GCC; see the file COPYING3.  If not see
 #define LIBGCCJIT_H
 
 #include <stdio.h>
+#include <sys/types.h>
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.39.3 (Apple Git-146)