From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 5F049389366C for ; Thu, 5 Aug 2021 16:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F049389366C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 27EDE22334; Thu, 5 Aug 2021 16:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1628182162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fyMW5XQcKZfv299BEm4gZapG75yVuIiXYncIhJfSmY=; b=zaxjmYR73ho8Q1+kyhkOjS1ladWI4X8PLnYQNbzjcd3m66t6SZiXZAYt1omog9ZfHdOzOJ efGJedFMNpaU9+QbrjJeiKkijuwzHhQei4zFjwLNchyH561CEp58yYIBu2N9pGPWzTMiku QUOR6XzuBblIEXbAJ77XnwHRR40ie4s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1628182162; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1fyMW5XQcKZfv299BEm4gZapG75yVuIiXYncIhJfSmY=; b=qQM8yRZujUh2Ld26XNEfO1IiHLJLRqOE8erJWIYwJreBDpATBFjhX6NPMakk4L3b/eFwx4 yBfaPtxQ4cVDs/Aw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 09EC513A5D; Thu, 5 Aug 2021 16:49:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id gubJAJIWDGGJZwAAGKfGzw (envelope-from ); Thu, 05 Aug 2021 16:49:22 +0000 Subject: Re: [PATCH] rs6000: Fix restored rs6000_long_double_type_size. To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org References: <94436f10-5012-6590-d059-428a8705377e@suse.cz> <20210623224610.GH5077@gate.crashing.org> <35838613-a5fe-8b46-e223-5120dfdd9adf@suse.cz> <20210712172048.GC1583@gate.crashing.org> <20210723175759.GP1583@gate.crashing.org> <20210805153948.GP1583@gate.crashing.org> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <71e22e72-890f-8a3e-7ab7-0699663006d5@suse.cz> Date: Thu, 5 Aug 2021 18:49:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805153948.GP1583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 16:49:24 -0000 On 8/5/21 5:39 PM, Segher Boessenkool wrote: > On Thu, Aug 05, 2021 at 02:05:24PM +0200, Martin Liška wrote: >> On 7/23/21 7:57 PM, Segher Boessenkool wrote: >>> Hi! >>> >>> On Fri, Jul 23, 2021 at 07:47:54AM +0200, Martin Liška wrote: >>>> On 7/12/21 7:20 PM, Segher Boessenkool wrote: >>>>>>>> +static __attribute__ ((optimize ("-fno-stack-protector"))) __typeof >>>>>>>> (f) * >>>>>>> >>>>>>> -fno-stack-protector is default. >>>>>> >>>>>> Yes, but one needs an optimize attribute in order to trigger >>>>>> cl_target_option_save/restore >>>>>> mechanism. >>>>> >>>>> So it behaves differently if you select the default than if you do not >>>>> select anything? That is wrong, no? >>>> >>>> Sorry, I don't get your example, please explain it. >>> >>> If -mbork is the default, the coompiler whould behave the same if you >>> invoke it with -mbork as when you do not. And the optimize attribute >>> should work exactly the same as command line options. >> >> Ah, got your point. All right, let's use then 'optimize(1)'. >> >> Is it fine with the adjustment? > > You are saying the compiler's behaviour is broken, but are changing the > testcase to avoid exhibiting that behaviour? No, both selections of the 'optimize' attribute trigger the ICE. The reason is that any optimize attribute triggers eventually cl_target_option_save/restore mechanism which is what the patch addresses. > No, this is not fine. > > If a flag is the default the compiler should do the same thing with and > without any attribute setting that flag, directly or indirectly. Yes, but should not crash. And that's what is my patch dealing with. Cheers, Martin > > > Segher >