From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1B0353858D32 for ; Thu, 7 Mar 2024 05:03:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1B0353858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1B0353858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709787828; cv=none; b=liTaUuDMw0h3BwFTAB+6Vj0KsfjXqwgCyc4dc44NjemqmhkE5gCdAbxLGaA2WGCS2k5emj/nuuDw+CfCKiVYwCAAm0DGUPRCxcurZ1bE7wapIfQ+KggJ36Di1n7h+Za2LRjykJrKy/mf6Lxd8VrsLTSqc9bcEEuneG0urCDPb+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709787828; c=relaxed/simple; bh=L8LB9D8GMJwqeR6vxtMBI+mKh+dTNdlmLiYqaFgkt0A=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=K65yYGU44ri44YvwTvynWMtCk4EBdgYYuR95u5Nh95rs02g7YultU79CbBJ3wM3l3hwEVogCT3HO5r/Wh6VgOcDQw2dAgXtgSUkvQLvUu4S0wQVfO3H73AwrT+lTn6Azaji7xNoaptDX9k6Hcn1oGzMgHn8xgo1cp7XxFpgf3F8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ri5ux-00014D-HT for gcc-patches@gcc.gnu.org; Thu, 07 Mar 2024 00:03:46 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8DxbOmlSullv5kVAA--.43597S3; Thu, 07 Mar 2024 13:03:33 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Ax3c6lSullUNJPAA--.15554S3; Thu, 07 Mar 2024 13:03:33 +0800 (CST) Subject: Re: [PATCH] LoongArch: Emit R_LARCH_RELAX for TLS IE with non-extreme code model to allow the IE to LE linker relaxation To: mengqinggang , Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20240229071309.57435-1-xry111@xry111.site> From: chenglulu Message-ID: <71e69e65-bc08-fa46-4efd-620125535b29@loongson.cn> Date: Thu, 7 Mar 2024 13:03:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Ax3c6lSullUNJPAA--.15554S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoW7Kr4xWw45uF4kWFyrCF13ZFc_yoW8GF43pr ykJa1UAFW8Crs5Gr1Utw1UJFySvw17t3WUWr93XF48XFs3tryagFyj9F90gryxJr4rJw17 Ww1UZr9ruFn8JrgCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUU9ab4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C2 67AKxVWUAVWUtwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI 8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWU CwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r 1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsG vfC2KfnxnUUI43ZEXa7IU8xuctUUUUU== Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9,NICE_REPLY_A=-1.194,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,KAM_STOCKGEN,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2024/3/7 下午12:05, mengqinggang 写道: > Hi, > > Thanks, this patch is LGTM. I don't have a problem either. Thanks. > > > 在 2024/3/7 上午10:56, Xi Ruoyao 写道: >> On Thu, 2024-03-07 at 10:43 +0800, mengqinggang wrote: >>> Hi, >>> >>> Whether to add an option to control the generation of R_LARCH_RELAX, >>> similar to as -mrelax/-mno-relax. >> There are already -mrelax and -mno-relax, they can be checked in the >> compiler code with TARGET_LINKER_RELAXATION. >> >> /* snip */ >> >>>> +    case 'Q': >>>> +      if (!TARGET_LINKER_RELAXATION) >>>> +         break; >> So with -mno-relax we'll break early here, then no R_LARCH_RELAX will be >> printed. >> >>>> +      if (code == HIGH) >>>> +         op = XEXP (op, 0); >>>> + >>>> +      if (loongarch_classify_symbolic_expression (op) == >>>> SYMBOL_TLS_IE) >>>> +         fprintf (file, ".reloc\t.,R_LARCH_RELAX\n\t"); >>>> + >>>> +      break; >> The tls-ie-norelax.c test case also checks for -mno-relax: >> >>>> +/* { dg-do compile } */ >>>> +/* { dg-options "-O2 -mcmodel=normal -mexplicit-relocs -mno-relax" >>>> } */ >>>> +/* { dg-final { scan-assembler-not "R_LARCH_RELAX" { target >>>> tls_native } } } */ >> i.e. -mno-relax is used compiling this test case, and the compiled >> assembly code should not contain R_LARCH_RELAX. >>