From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BD5413858D28; Tue, 11 Apr 2023 09:14:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BD5413858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33B6vteY014544; Tue, 11 Apr 2023 09:14:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=mime-version : date : from : to : cc : subject : in-reply-to : references : message-id : content-type : content-transfer-encoding; s=pp1; bh=eFnIfGas2RQTEzDgJZr5B9jGPwCYFpz4WktNtfrlgiw=; b=mqluTjtnpzyXN2aTQGqaZ9riGAbK9HMLHWDME2N2rWqgTEEmCtqRAjzCNX6LqOPmCKpQ vypfKrHge6gs/z9MC/9EOhQGxzGFlR/zicA97wqjK8H10g0KAj55YOoneO5HImsDVImU dDtuOYJ5KWqanYUVoLwKnYv5jA2ml9gbCqNX6GwX1mFIsKe/Dn1ELWAHcGxaRvzI83ed iVO0ZVTBQW9ICTHvRdU8euVy93w87gSO6a8depZxEHYgrZbNBEFBSP6k2ewMPn09CI8g zKoF0U/NSaNBeULHuJY7iz7ridP6tcGk2F8z1uGEODdQvtIjVyIGRMKCTflTcb4HhFew 3w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pvrr8srp9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2023 09:14:35 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33B8tnsv026355; Tue, 11 Apr 2023 09:14:34 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pvrr8srnk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2023 09:14:34 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33B7p7EL020834; Tue, 11 Apr 2023 09:14:33 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([9.208.129.118]) by ppma04wdc.us.ibm.com (PPS) with ESMTPS id 3pu0jgyj9a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Apr 2023 09:14:33 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33B9EV5m11076220 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Apr 2023 09:14:32 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB1ED58059; Tue, 11 Apr 2023 09:14:31 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5C8D95804B; Tue, 11 Apr 2023 09:14:31 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Apr 2023 09:14:31 +0000 (GMT) MIME-Version: 1.0 Date: Tue, 11 Apr 2023 17:14:31 +0800 From: guojiufu To: "Kewen.Lin" Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, meissner@linux.ibm.com, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c In-Reply-To: <11b29ca1-cd23-1a48-4ad8-3b472d38fd2f@linux.ibm.com> References: <20230410020941.2440885-1-guojiufu@linux.ibm.com> <11b29ca1-cd23-1a48-4ad8-3b472d38fd2f@linux.ibm.com> Message-ID: <71ed6f665ae2ed9678d8dc4ec0f620ce@linux.ibm.com> X-Sender: guojiufu@linux.ibm.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: g66w8pN02K9VExG5f_VML7km229ZInEa X-Proofpoint-ORIG-GUID: R0LgSzb4Pk6TVvUBFJRk3AeHc95W2YDa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-11_05,2023-04-06_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 suspectscore=0 impostorscore=0 mlxscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304110085 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kewen, Thanks a lot for your very helpful comments! On 2023-04-10 17:26, Kewen.Lin wrote: > Hi Jeff, > > on 2023/4/10 10:09, Jiufu Guo via Gcc-patches wrote: >> Hi, >> >> In this test case (float128-cmp2-runnable.c), the instruction >> xscmpexpqp is used to support a few builtins e.g. >> __builtin_vsx_scalar_cmp_exp_qp_eq on _Float128. >> This instruction handles the whole 128bits of the vector, and >> it is guarded by [ieee128-hw]. > > The instruction xscmpexpqp is guarded with TARGET_P9_VECTOR, > > (define_insn "*xscmpexpqp" > [(set (match_operand:CCFP 0 "cc_reg_operand" "=y") > (compare:CCFP > (unspec:IEEE128 [(match_operand:IEEE128 1 "altivec_register_operand" > "v") > (match_operand:IEEE128 2 "altivec_register_operand" "v")] > UNSPEC_VSX_SCMPEXPQP) > (match_operand:SI 3 "zero_constant" "j")))] > "TARGET_P9_VECTOR" > "xscmpexpqp %0,%1,%2" > [(set_attr "type" "fpcompare")]) > > [ieee128-hw] is used for guarding those bifs, so the above > statement doesn't quite match the fact. > Agree, I'm wondering if P9_VECTOR is perfect here, even if it indicates the ISA which contains xscmpexpqp. Let me have more checks. > PR108758 said this case doesn't fail with gcc-10 and gcc-11, > I wonder why it changes from gcc-12? The above define_insn > shows the underlying insns for these bifs just requires the > condition power9-vector. Could you have a further check? > Thanks. Thanks for raising this concern. The behavior to check about bif on FLOAT128_HW and emit an error message for requirements on quad-precision is added in gcc12. This is why gcc12 fails to compile the case on -m32. Before gcc12, altivec_resolve_overloaded_builtin will return the overloaded result directly, and does not check more about the result function. > > btw, please add a PR marker for PR108758. Sure, thanks for catching this! BR, Jeff (Jiufu) > > BR, > Kewen > >> So, we may update the testcase to require ppc_float128_hw. >> >> Tested on ppc64 both BE and LE. >> Is this ok for trunk? >> >> BR, >> Jeff (Jiufu) >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/powerpc/float128-cmp2-runnable.c: Update requires. >> >> --- >> gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c >> b/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c >> index d376a3ca68e..91287c0fb7a 100644 >> --- a/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c >> +++ b/gcc/testsuite/gcc.target/powerpc/float128-cmp2-runnable.c >> @@ -1,5 +1,5 @@ >> /* { dg-do run } */ >> -/* { dg-require-effective-target ppc_float128_sw } */ >> +/* { dg-require-effective-target ppc_float128_hw } */ >> /* { dg-require-effective-target p9vector_hw } */ >> /* { dg-options "-O2 -mdejagnu-cpu=power9 " } */ >>