From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61005 invoked by alias); 17 Jan 2017 16:39:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60965 invoked by uid 89); 17 Jan 2017 16:39:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*MI:sk:587E084, H*i:sk:587E084, H*f:sk:587E084, opportunity X-HELO: mail-yw0-f182.google.com Received: from mail-yw0-f182.google.com (HELO mail-yw0-f182.google.com) (209.85.161.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jan 2017 16:39:08 +0000 Received: by mail-yw0-f182.google.com with SMTP id l19so92574755ywc.2 for ; Tue, 17 Jan 2017 08:39:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=TFRwJ2FmFXOoxb3eegUyeDtJyYpS3EuplYnpa0LKc4c=; b=GVPSrXwqSMda3CmMRLZ8NH3hPol49MM9tvH9EOIQDs8zBCn4w2f/6+bc3GJYSADT+I 5du/SFNzWGRxVn6rM+eyBVY/CzLYKbcgY/kpZeMF+eV8pbdhBXTlLrU3LxGdLjw8o9oQ PHofCO1TcSlQux3MUbyVWGbOzkIH2/6+wH6fjowg9gZMX18vcR8ylR6ze3ofojLPy2PW 8OUShs9+Ot+A2CbpEHD686/XJlueTu0JlS/4uv9CZqZlahCXob2kRCaecWDJ5Uu3IU+U xu82MS+xy2Gn/UflZzkG+14fbTazCd4oqfNP6wXIwfe3C/CeyVRXMwnPJKhHbIzzYeVw 3fnQ== X-Gm-Message-State: AIkVDXIcPRuKa9PgZz2upDDK0F8SnrmhQphmdk8nXHNfbUvIk5eg2oWRGzksFb+ZiyZzaQ== X-Received: by 10.55.53.77 with SMTP id c74mr4298014qka.7.1484671146990; Tue, 17 Jan 2017 08:39:06 -0800 (PST) Received: from [192.168.0.3] (97-118-114-123.hlrn.qwest.net. [97.118.114.123]) by smtp.gmail.com with ESMTPSA id c198sm19156980qka.48.2017.01.17.08.39.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 08:39:06 -0800 (PST) From: Martin Sebor Subject: Re: [PATCH] adding missing LTO to some warning options (PR 78606) To: Kyrill Tkachov , Gcc Patch List , Richard Biener References: <06c24069-90af-5778-52a2-c9167eb109ab@gmail.com> <587E0848.1000300@foss.arm.com> Message-ID: <72187d84-8e35-ea6a-666a-aa1c26ee51ca@gmail.com> Date: Tue, 17 Jan 2017 16:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <587E0848.1000300@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg01235.txt.bz2 On 01/17/2017 05:04 AM, Kyrill Tkachov wrote: > Hi Martin, > > On 10/01/17 22:16, Martin Sebor wrote: >> The -Walloca-larger-than, -Wformat-length, and -Wformat-truncation >> options do not mention LTO among the supported languages and so are >> disabled when -flto is used, causing false negatives. >> >> The attached patch adds the missing LTO to the three options. This >> makes -Walloca-larger-than work with LTO but not the other two >> options, implying that something else is preventing the gimple-ssa- >> sprintf pass from running when -flto is enabled. I haven't had >> the cycles to look into what that might be yet. Since the root >> causes are independent I'd like to commit this patch first and >> deal with the -Wformat-{length,truncation} problem separately, >> under a new bug (or give someone with a better understanding of >> LTO the opportunity to do it). >> > > I see the new test FAILing on arm and aarch64 targets. > FAIL: gcc.dg/pr78768.c execution test Thanks. The test doesn't need to run. It just needs to link. I changed it in r244537. Martin