From: Mike Stump <mikestump@comcast.net>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gcc-patches@gcc.gnu.org, Richard Guenther <rguenther@suse.de>
Subject: Re: [lto, testsuite] Don't use visibility on targets that don't support it (PR lto/47334)
Date: Thu, 09 Jun 2011 18:52:00 -0000 [thread overview]
Message-ID: <72433EF7-7659-424F-9312-AC455F4635FB@comcast.net> (raw)
In-Reply-To: <yddk4cvfpcq.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On Jun 9, 2011, at 12:14 AM, Rainer Orth wrote:
> Mike Stump <mikestump@comcast.net> writes:
>> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote:
>>> * lto.c (promote_var): Only set VISIBILITY_HIDDEN if
>>> HAVE_GAS_HIDDEN.
>>
>> This looks wrong, there are more things that have visibility than those things that use GAS and have .hidden. Darwin I think is one of them. ? cygming.h seems to be another.
>
> Now that Darwin has been switched to define HAVE_GAS_HIDDEN, is the
> lto.c part ok?
I don't have any lto specific objections related to this.
next prev parent reply other threads:[~2011-06-09 18:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 8:56 Rainer Orth
2011-04-05 9:47 ` Richard Guenther
2011-04-05 17:42 ` Mike Stump
2011-04-05 18:11 ` Rainer Orth
2011-06-09 7:33 ` Rainer Orth
2011-06-09 9:51 ` Richard Guenther
2011-06-09 10:00 ` Jan Hubicka
2011-06-09 18:52 ` Mike Stump [this message]
2011-04-05 17:44 ` Mike Stump
2011-04-05 18:21 ` Rainer Orth
2011-04-19 18:31 ` Rainer Orth
2011-04-20 8:26 ` Mike Stump
2011-04-21 13:04 ` Rainer Orth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72433EF7-7659-424F-9312-AC455F4635FB@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
--cc=ro@CeBiTec.Uni-Bielefeld.DE \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).