From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 625 invoked by alias); 11 Feb 2019 12:31:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 534 invoked by uid 89); 11 Feb 2019 12:31:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Feb 2019 12:31:27 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id B144881382; Mon, 11 Feb 2019 13:31:25 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v9G1WFz03cuG; Mon, 11 Feb 2019 13:31:25 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 9196E8137C; Mon, 11 Feb 2019 13:31:25 +0100 (CET) From: Eric Botcazou To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [patch] Disable store merging in asan_expand_mark_ifn Date: Mon, 11 Feb 2019 12:31:00 -0000 Message-ID: <7245552.sqmLjyS5Qn@polaris> In-Reply-To: <20190211115659.GC2135@tucnak> References: <4495488.sKnqla6Psi@polaris> <3232010.dzHkQe7i9D@polaris> <20190211115659.GC2135@tucnak> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2019-02/txt/msg00739.txt.bz2 > No. 64-bit aligned offsets too. If you know 64-bit alignment of base_addr, > you can use size 2 stores (though not size 4 stores) on the > !STRICT_ALIGNMENT targets. And that is something still pretty common. But we're talking about STRICT_ALIGNMENT targets here: an array of 2 doubles at address 0x10000008 will have a shadow address of 0x20000001 modulo the offset so you cannot use size 2. Moveover the store merging pass should be able to merge the stores so I don't really understand why this matters at all. -- Eric Botcazou