From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 649CB384A87E for ; Sat, 24 Oct 2020 01:37:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 649CB384A87E Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-OqUlwyzUNYaYUj75_s16AQ-1; Fri, 23 Oct 2020 21:37:21 -0400 X-MC-Unique: OqUlwyzUNYaYUj75_s16AQ-1 Received: by mail-qt1-f200.google.com with SMTP id z22so2684791qtn.15 for ; Fri, 23 Oct 2020 18:37:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HU5C6Wc2VAwNDXq/hOsfRX2PqObjTpZYhwTxs5k/5NA=; b=syoRaVov6LnsIfZMtw35xnVsOrCmTBuiOyL4jSTrnY0jMzOsP+BA1pVqKRJNzVAMnY e8RpNn5WWyYc//H8/eoNVwjMap587VIwCb6vjHeIwWPesA5SLwf+OzZFwojDSEq3dYO8 0WwbAjJ+GH9JQ/KInbWRCrp+HgXsx1cU3q6sW6KA3YEW9zlHxynLdWOSOL70XTe/qABo hO4ukRex/HbE0hkKXHkmlnQSfHPNXKrlO1koRpINTZqCjZj49H/lXrD7058q5OX4wGrK l+OWXLc23C9grQ8x7M87beqCfeQW0Jb8Tdrvk5io/A6iAT0twBZiQO+sEzXdRwo3Xoj8 kK4g== X-Gm-Message-State: AOAM530lJuDMeX62jA7f4oj+xuQouM8p2qBg5JcLIcgfnkP4t4Ku8o1H rcBvIT9LqVZgLVBZK9rgm91cQ1ArKdy/lr6RDg9SaEtb3tbowcJ0IHsWT0zs20TFj6DinSOxTBu zsPzI5/RXsQfyACCp7Q== X-Received: by 2002:a37:51c6:: with SMTP id f189mr5481220qkb.276.1603503440981; Fri, 23 Oct 2020 18:37:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXxSsJVmIh5VN1cHghORpM1Z5al3cJh5xt7tHO26dmsJFOIzL+ibwufVilJVW8fNwootleZg== X-Received: by 2002:a37:51c6:: with SMTP id f189mr5481209qkb.276.1603503440746; Fri, 23 Oct 2020 18:37:20 -0700 (PDT) Received: from [192.168.1.148] (209-6-216-142.s141.c3-0.smr-cbr1.sbo-smr.ma.cable.rcncustomer.com. [209.6.216.142]) by smtp.gmail.com with ESMTPSA id f4sm2302705qtd.35.2020.10.23.18.37.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Oct 2020 18:37:19 -0700 (PDT) Subject: Re: [PATCH] g++, libstdc++: implement __is_nothrow_{constructible, assignable} To: Ville Voutilainen , Marek Polacek Cc: gcc-patches List , libstdc++ References: <20201024000025.GP3628@redhat.com> From: Jason Merrill Message-ID: <726cde93-b7d5-edb1-99b3-c02ebaefcff6@redhat.com> Date: Fri, 23 Oct 2020 21:37:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 01:37:24 -0000 On 10/23/20 8:03 PM, Ville Voutilainen wrote: > On Sat, 24 Oct 2020 at 03:00, Marek Polacek wrote: >>> + tree expr; >>> + expr = is_xible_helper (code, to, from, /*trivial*/false); >> >> tree expr = is_xible_helper (code, to, from, /*trivial*/false); >> >> would be nicer, otherwise the front-end changes look fine, thanks. > > Ha, we have the same thing in is_trivially_xible, so I'll drive-by > change that one as well. OK with that change. Jason