public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: [PATCH,rs6000] PR80108: Fix ICE with cross compiler
       [not found] <edeee04a-1c4d-0dcb-ef63-4b2c2857a74b@linux.vnet.ibm.com>
@ 2017-04-03 15:56 ` Pat Haugen
  2017-04-03 17:44   ` Segher Boessenkool
  0 siblings, 1 reply; 2+ messages in thread
From: Pat Haugen @ 2017-04-03 15:56 UTC (permalink / raw)
  To: Kelvin Nilsen, gcc-patches; +Cc: Segher Boessenkool

On 03/31/2017 06:28 PM, Kelvin Nilsen wrote:
> +! { dg-do compile { target { powerpc*-*-* } } }
> +! { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power9" } }

Shouldn't it be -mcpu=405 in the exclude string since that's what's
specified below?

> +! { dg-require-effective-target powerpc_p9vector_ok }
> +! { dg-options "-m32 -mcpu=405 -mpower9-minmax -mfloat128-type" }

-m32 is invalid for LE, so the test should be skipped for powerpc64le.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH,rs6000] PR80108: Fix ICE with cross compiler
  2017-04-03 15:56 ` [PATCH,rs6000] PR80108: Fix ICE with cross compiler Pat Haugen
@ 2017-04-03 17:44   ` Segher Boessenkool
  0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-04-03 17:44 UTC (permalink / raw)
  To: Pat Haugen; +Cc: Kelvin Nilsen, gcc-patches

On Mon, Apr 03, 2017 at 10:56:50AM -0500, Pat Haugen wrote:
> On 03/31/2017 06:28 PM, Kelvin Nilsen wrote:
> > +! { dg-do compile { target { powerpc*-*-* } } }
> > +! { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power9" } }
> 
> Shouldn't it be -mcpu=405 in the exclude string since that's what's
> specified below?
> 
> > +! { dg-require-effective-target powerpc_p9vector_ok }
> > +! { dg-options "-m32 -mcpu=405 -mpower9-minmax -mfloat128-type" }
> 
> -m32 is invalid for LE, so the test should be skipped for powerpc64le.

Or instead of setting -m32, just test for it?


Segher

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-03 17:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <edeee04a-1c4d-0dcb-ef63-4b2c2857a74b@linux.vnet.ibm.com>
2017-04-03 15:56 ` [PATCH,rs6000] PR80108: Fix ICE with cross compiler Pat Haugen
2017-04-03 17:44   ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).