From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=px6/=KD=arm.com=Richard.Earnshaw@sourceware.org>
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by sourceware.org (Postfix) with ESMTP id B006D3858C55
	for <gcc-patches@gcc.gnu.org>; Mon, 26 Feb 2024 16:13:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B006D3858C55
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B006D3858C55
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708963992; cv=none;
	b=nQTAZ7UWvrgXMvRyWlEgFCB/5iF0PxOsNxDXTVEzRuwAACEykCUFLq1KpgKsQ4GhszWmG8SD6Qz2ta8Oww+sKrpPzlpaM9onzbUMAXU8Al1Y3gKSV0B59NETlimaWXjB+psX+sclmeCBRzHX80LMAQPElh6Cbvi7k7YTPOvqOFM=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1708963992; c=relaxed/simple;
	bh=1xUJZ93lFdL+Oxd9NHOPLi0nnkljszYpCCYzTM4FmCM=;
	h=Message-ID:Date:MIME-Version:Subject:To:From; b=WFSdFFkKGZfs/9VQ8DA6uC9UPd0xHxsTQyoM1mKuVmgFoz+eOAAs+Ds4ADYxVnYnfZYQ/Be0AcsGDQOfU9m44FMWgg7Hkewv+LRuCLLaSWqMgaEE3bRhNfFX75yv60lL25m9LdJ+tflDRSpGGDn6AzR8PWVtkUUZdONyKP0R1uI=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B1968DA7;
	Mon, 26 Feb 2024 08:13:48 -0800 (PST)
Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 815FF3F73F;
	Mon, 26 Feb 2024 08:13:09 -0800 (PST)
Message-ID: <72891704-ee54-4a74-8bb5-318ea34891f7@arm.com>
Date: Mon, 26 Feb 2024 16:13:08 +0000
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ARM: Fix conditional execution [PR113915]
Content-Language: en-GB
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
 Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
References: <PAWPR08MB8982C55211A0F7A7C1813D1F83572@PAWPR08MB8982.eurprd08.prod.outlook.com>
 <d4dcd4a0-e99c-46a5-8ddb-38842688985c@arm.com>
 <PAWPR08MB8982EC0E8F95B5DAEC68FB0F83552@PAWPR08MB8982.eurprd08.prod.outlook.com>
 <a5e74777-79cd-4025-ade1-fa119d680172@arm.com>
 <PAWPR08MB89825DE72CC8B2BF3C73D73C835A2@PAWPR08MB8982.eurprd08.prod.outlook.com>
From: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
In-Reply-To: <PAWPR08MB89825DE72CC8B2BF3C73D73C835A2@PAWPR08MB8982.eurprd08.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3491.7 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 26/02/2024 16:05, Wilco Dijkstra wrote:
> Hi Richard,
> 
>> Did you test this on a thumb1 target?  It seems to me that the target parts that you've
>> removed were likely related to that.  In fact, I don't see why this test would need to be changed at all.
> 
> The testcase explicitly forces a Thumb-2 target (arm_arch_v6t2). The patterns
> were wrong for Thumb-2 indeed, and the testcase was explicitly testing for this.
> There is a separate builtin-bswap-2.c for Thumb-1 target (arm_arch_v6m).
> 
> Cheers,
> Wilco

That's why statements like:

        * gcc.target/arm/builtin-bswap-1.c: Fix test.

are less than helpful.  Perhaps if you'd said what you actually changed that would have made it more obvious.

So OK, but please fix the commit message to say what you did.

R.