From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117330 invoked by alias); 20 Feb 2019 15:21:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117309 invoked by uid 89); 20 Feb 2019 15:21:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mass, Sunday, sunday X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Feb 2019 15:21:28 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 188252DD78D; Wed, 20 Feb 2019 15:21:27 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-27.rdu2.redhat.com [10.10.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19AE45D71B; Wed, 20 Feb 2019 15:21:24 +0000 (UTC) Subject: Re: Move -Wmaybe-uninitialized to -Wextra To: Martin Sebor , Pedro Alves , Marc Glisse , Martin Jambor Cc: gcc-patches@gcc.gnu.org References: <5748265d-a95a-1af3-2783-aabc6919d2ea@gmail.com> <9dd9717b-3465-a8b6-6407-25b5c764479b@redhat.com> <0507a183-70db-d2d5-e7c3-b3560a433f3c@redhat.com> From: Jeff Law Openpgp: preference=signencrypt Message-ID: <72901a63-c4ae-6212-492a-d70348bb410d@redhat.com> Date: Wed, 20 Feb 2019 16:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg01676.txt.bz2 On 2/20/19 8:11 AM, Martin Sebor wrote: > On 2/20/19 7:25 AM, Jeff Law wrote: >> On 2/20/19 5:36 AM, Pedro Alves wrote: >>> On 02/05/2019 05:07 PM, Jeff Law wrote: >>>> FWIW, I've been doing Fedora rawhide builds with gcc-9 since early Jan. >>>>   Not everything builds with -Wall -Werror, but lots of packages do. >>>> I've only seen one maybe-uninit warning cause problems -- it was >>>> spurious and for a memory object.  I didn't dig into it at all. >>> >>> Do you have insight into how many Fedora packages explicitly disable >>> maybe-uninit?  I really don't know the answer to that, but I'd at least >>> keep that in mind as a possible reason for the warning seemingly >>> not causing trouble often. >> Unfortunately not.  And my tester only saves failed log files, so I >> can't just grep the log files for it. > > Would it difficult to add a pass over the build logs to scan for > these sorts of things?  E.g., count the number of instances of > each warning in builds that don't use -Werror? It's essentially the same as saving the successful logs :-) Everything is built with fedpkg which buries the log files. For a failed build the scripts dig them out of the filesystem and dump them to stdout. Doing the same for a successful build wouldn't be hard. Once that's in place we can scan for warnings or whatever else, even in a successful build. I'll try to get that added for the next mass test which would start Sunday after the next gcc-9 snapshot. jeff