From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id F13B63858D39 for ; Thu, 29 Sep 2022 13:32:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F13B63858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x42f.google.com with SMTP id cc5so2226212wrb.6 for ; Thu, 29 Sep 2022 06:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=to:cc:date:message-id:subject:mime-version:from:from:to:cc:subject :date; bh=ZeCkZZdMPkmpSTLECxZ6tHx3+9FmkyAMsnkvVbklUJY=; b=A8EbXJ+YI4kdbOVL9L8/uzO7gB2VaqOPzEvnqYT13VBiBwRWTepHveofo4whVg4sEE x9SU/l3fz8OMuXS1Kz9a5PAscs1ZPUAXf9h+dnv6pc1UNFXUx9pJrdX16qQL6rafeDjA Pieo35TENkKF/WN7HXpIIhajxwxhFKY8itUI0XO7qkm+BnsRg5crh2wnp2IkPB1vnQi7 B+3ihPd+Zp2F7BMCFnh4y3kACSNQPQwrBIqqQy3tEfgl9mf0lM4ORY8lRUmCZQtJ3w1w ivUlU0dGK9h8RgynV6/Zv3xuDT3inrQdEhuOqsFwdB2bXrKnumnThtJtoPUMrTNOmuVj 2g3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date; bh=ZeCkZZdMPkmpSTLECxZ6tHx3+9FmkyAMsnkvVbklUJY=; b=3d2BaRzvBgoLCrceJHrew8zQ3WIDAdIylmDlMH4/a8HAdW97b2b3ZtIDrV1co4RVJI vy/iLZ4YA6Z4tzF46TP6MHfTwfyQpNmMiihgd/jX656tB5xKtlxrE7iKgi7qplEVygNG beq/fA4P9NHqxGWlnnf+wwwoDXu0VYbMnu1E2Vt4aQZlBMipoklFb6M98Znx+mLtfds4 SUiC7eGS3nBeWqpONl2BDUkySmjEEPKYS4pfqXMlD8mWv1xXWwH0rlUn7AXkuWtUSJzO S6khhiEfksudLtwIySao77Z9b6qNblrh5ABkqze0Qa4IcVOwIReQsFwmsb/171CsHJLC 0+MQ== X-Gm-Message-State: ACrzQf0WPHPVZNSpgeKt8sq5/Vl7d46FiSdSt2mi7EKEG/VwaeeMu+F0 u1FHPRQmVW32rhcjpzUHjA7oqxtlZUMAFw== X-Google-Smtp-Source: AMsMyM5w/iJcXYOEK+6lsqcJoxEkvl9mRlafBP8cbW1cVSst4Ht+B/OYpktdC725p/R6KlwL1vBQfw== X-Received: by 2002:a5d:65c4:0:b0:22c:dbdd:7177 with SMTP id e4-20020a5d65c4000000b0022cdbdd7177mr993992wrw.470.1664458356587; Thu, 29 Sep 2022 06:32:36 -0700 (PDT) Received: from smtpclient.apple ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id h5-20020a05600c28c500b003b50428cf66sm4243521wmd.33.2022.09.29.06.32.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Sep 2022 06:32:35 -0700 (PDT) From: Olivier Hainque Content-Type: multipart/mixed; boundary="Apple-Mail=_25C276FA-887B-4B87-B477-2F0EAC296310" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: [patch] Remove TARGET_FLOAT128_ENABLE_TYPE setting for VxWorks Message-Id: <729A80D9-4B61-463C-AFF2-BC7B3A9CE57C@adacore.com> Date: Thu, 29 Sep 2022 15:32:34 +0200 Cc: Olivier Hainque To: gcc-patches X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --Apple-Mail=_25C276FA-887B-4B87-B477-2F0EAC296310 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hello, We have, in vxworks.h: /* linux64.h enables this, not supported in vxWorks. */ #undef TARGET_FLOAT128_ENABLE_TYPE #define TARGET_FLOAT128_ENABLE_TYPE 0 We inherit linux64.h for a few reasons, but don't really support float128 for vxworks, so the setting made sense. Many tests rely on the linux default (1) though, so resetting is causing lots of failures on compilation tests that would pass otherwise. Not resetting lets users write code declaring floa128 objects but linking will typically fail at some point, so there's no real adverse effect. Bottom line is we don't have any particular incentive to alter the default, whatever the default, so better leave the parameter alone. Tested with internal testsuites for VxWorks and the dg testsuite on a variety of gcc-11 based compilers. Checked that the compiler still builds and passes a few internal testsuites with a gcc-12 compiler for ppc64-vx7r2. Committing to mainline. Olivier 2022-04-19 Olivier Hainque * config/vxworks.h (TARGET_FLOAT128_ENABLE_TYPE): Remove resetting to 0. --Apple-Mail=_25C276FA-887B-4B87-B477-2F0EAC296310 Content-Disposition: attachment; filename=0002-Remove-TARGET_FLOAT128_ENABLE_TYPE-setting-for-VxWor.patch Content-Type: application/octet-stream; x-unix-mode=0640; name="0002-Remove-TARGET_FLOAT128_ENABLE_TYPE-setting-for-VxWor.patch" Content-Transfer-Encoding: quoted-printable =46rom=203ebde07b2811d5ac2073ec2f89260e582279a563=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Olivier=20Hainque=20=0A= Date:=20Tue,=2019=20Apr=202022=2009:07:32=20+0000=0ASubject:=20[PATCH=20= 02/18]=20Remove=20TARGET_FLOAT128_ENABLE_TYPE=20setting=20for=20VxWorks=0A= =0AWe=20have,=20in=20vxworks.h:=0A=0A=20=20/*=20linux64.h=20enables=20= this,=20not=20supported=20in=20vxWorks.=20=20*/=0A=20=20#undef=20= TARGET_FLOAT128_ENABLE_TYPE=0A=20=20#define=20= TARGET_FLOAT128_ENABLE_TYPE=200=0A=0AWe=20inherit=20linux64.h=20for=20a=20= few=20reasons,=20but=20don't=20really=20support=0Afloat128=20for=20= vxworks,=20so=20the=20setting=20made=20sense.=0A=0AMany=20tests=20rely=20= on=20the=20linux=20default=20(1)=20though,=20so=20resetting=20is=0A= causing=20lots=20of=20failures=20on=20compilation=20tests=20that=20would=20= pass=20otherwise.=0A=0ANot=20resetting=20lets=20users=20write=20code=20= declaring=20floa128=0Aobjects=20but=20linking=20will=20typically=20fail=20= at=20some=20point,=20so=0Athere's=20no=20real=20adverse=20effect.=0A=0A= Bottom=20line=20is=20we=20don't=20have=20any=20particular=20incentive=20= to=20alter=0Athe=20default,=20whatever=20the=20default,=20so=20better=20= leave=20the=20parameter=0Aalone.=0A=0A2022-04-19=20=20Olivier=20Hainque=20= =20=0A=0A=09*=20config/vxworks.h=20= (TARGET_FLOAT128_ENABLE_TYPE):=20Remove=0A=09resetting=20to=200.=0A---=0A= =20gcc/config/rs6000/vxworks.h=20|=204=20----=0A=201=20file=20changed,=20= 4=20deletions(-)=0A=0Adiff=20--git=20a/gcc/config/rs6000/vxworks.h=20= b/gcc/config/rs6000/vxworks.h=0Aindex=206f11de6c579..e9626505d4b=20= 100644=0A---=20a/gcc/config/rs6000/vxworks.h=0A+++=20= b/gcc/config/rs6000/vxworks.h=0A@@=20-265,9=20+265,5=20@@=20along=20with=20= GCC;=20see=20the=20file=20COPYING3.=20=20If=20not=20see=0A=20#undef=20= LINK_OS_EXTRA_SPEC64=0A=20#define=20LINK_OS_EXTRA_SPEC64=20= VXWORKS_LINK_SPEC=0A=20=0A-/*=20linux64.h=20enables=20this,=20not=20= supported=20in=20vxWorks.=20=20*/=0A-#undef=20= TARGET_FLOAT128_ENABLE_TYPE=0A-#define=20TARGET_FLOAT128_ENABLE_TYPE=200=0A= -=0A=20#endif=20/*=20TARGET_VXWORKS7=20*/=0A=20=0A--=20=0A2.25.1=0A=0A= --Apple-Mail=_25C276FA-887B-4B87-B477-2F0EAC296310--